Date: Mon, 1 Nov 2021 20:37:40 +0100
From: Juraj Lutter <otis@FreeBSD.org>
To: Tobias Kortkamp <tobik@FreeBSD.org>
Cc: Yasuhiro Kimura <yasu@freebsd.org>, ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject: Re: git: d356121270d7 - main - mail/postfix{,-ldap-sasl,-sasl}: Flavorize
Message-ID: <85E45344-2BEE-48D0-A460-F62CD1B152CA@FreeBSD.org>
In-Reply-To: <YYA1j9FOjGd6vxz0@loki.kortkamp.xyz>
References: <202110280007.19S07MMW076891@gitrepo.freebsd.org> <YYA1j9FOjGd6vxz0@loki.kortkamp.xyz>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_901BB004-11CF-45C8-993F-9FC979031B14
Content-Type: multipart/alternative;
boundary="Apple-Mail=_15B541AF-7859-4E45-AC8A-F533A7511EA3"
--Apple-Mail=_15B541AF-7859-4E45-AC8A-F533A7511EA3
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=utf-8
Hi,
> On 1 Nov 2021, at 19:44, Tobias Kortkamp <tobik@FreeBSD.org> wrote:
>=20
> On Thu, Oct 28, 2021 at 12:07:22AM +0000, Yasuhiro Kimura wrote:
>> -POSTFIX_CCARGS+=3D -DDEF_CONFIG_DIR=3D\\\"${ETCDIR}\\\" \
>> - -DDEF_DAEMON_DIR=3D\\\"${DAEMONDIR}\\\" \
>> - -DDEF_META_DIR=3D\\\"${META_DIRECTORY}\\\" \
>> - -DDEF_COMMAND_DIR=3D\\\"${PREFIX}/sbin\\\" \
>> - =
-DDEF_SENDMAIL_PATH=3D\\\"${PREFIX}/sbin/sendmail\\\" \
>> - =
-DDEF_NEWALIAS_PATH=3D\\\"${PREFIX}/bin/newaliases\\\" \
>> - -DDEF_MAILQ_PATH=3D\\\"${PREFIX}/bin/mailq\\\" \
>> - -DDEF_MANPAGE_DIR=3D\\\"${MANPREFIX}/man\\\" \
>> - -DDEF_README_DIR=3D\\\"${READMEDIR}\\\" \
>> - -DDEF_HTML_DIR=3D\\\"${READMEDIR}\\\" \
>> - -DDEF_QUEUE_DIR=3D\\\"/var/spool/postfix\\\" \
>> - -DDEF_DATA_DIR=3D\\\"/var/db/postfix\\\" \
>> - -DDEF_MAIL_OWNER=3D\\\"postfix\\\" \
>> - -DDEF_SGID_GROUP=3D\\\"maildrop\\\" \
>> - -Wmissing-prototypes -Wformat -Wno-comment
>> +POSTFIX_CCARGS+=3D -DDEF_CONFIG_DIR=3D\\\"${ETCDIR}\\\" =
-DDEF_DAEMON_DIR=3D\\\"${DAEMONDIR}\\\" =
-DDEF_META_DIR=3D\\\"${META_DIRECTORY}\\\" =
-DDEF_COMMAND_DIR=3D\\\"${PREFIX}/sbin\\\" =
-DDEF_SENDMAIL_PATH=3D\\\"${PREFIX}/sbin/sendmail\\\" =
-DDEF_NEWALIAS_PATH=3D\\\"${PREFIX}/bin/newaliases\\\" =
-DDEF_MAILQ_PATH=3D\\\"${PREFIX}/bin/mailq\\\" =
-DDEF_MANPAGE_DIR=3D\\\"${MANPREFIX}/man\\\" =
-DDEF_README_DIR=3D\\\"${READMEDIR}\\\" =
-DDEF_HTML_DIR=3D\\\"${READMEDIR}\\\" =
-DDEF_QUEUE_DIR=3D\\\"/var/spool/postfix\\\" =
-DDEF_DATA_DIR=3D\\\"/var/db/postfix\\\" =
-DDEF_MAIL_OWNER=3D\\\"postfix\\\" -DDEF_SGID_GROUP=3D\\\"maildrop\\\" =
-Wmissing-prototypes -Wformat -Wno-comment
>=20
> Hi,
>=20
> this is caused by a tokenizer bug in portfmt where it treated
> the entire thing as one word. It is not ok for portfmt to format
> POSTFIX_CCARGS like that. I fixed it in [0].
>=20
> Sorry, I saw it in the review earlier but forgot to comment on
> it. Please report stuff like this to me on GitHub [1] or on
> Bugzilla.
>=20
I will commit a better readable Makefile without any functional changes.
Thanks anyway for portfmt update :-)
otis
=E2=80=94
Juraj Lutter
otis@FreeBSD.org
--Apple-Mail=_15B541AF-7859-4E45-AC8A-F533A7511EA3--
--Apple-Mail=_901BB004-11CF-45C8-993F-9FC979031B14
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP
-----BEGIN PGP SIGNATURE-----
iHUEAREIAB0WIQR9WLqI3W4V0bRHtaAtyIKFszIZVAUCYYBCBAAKCRAtyIKFszIZ
VHy7AP0dVzjWS45GlUt2PP1M8k9Y/tExpDkCDGYRKOVMihZsVAEAnJZM2+m13oq8
lc1DOsNKWc8F/XmY1e8u5nRdwgBoLqI=
=+/pG
-----END PGP SIGNATURE-----
--Apple-Mail=_901BB004-11CF-45C8-993F-9FC979031B14--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?85E45344-2BEE-48D0-A460-F62CD1B152CA>