Date: Sat, 16 Dec 1995 16:38:49 -0500 From: John Capo <jc@irbs.com> To: FreeBSD-gnats-submit@freebsd.org Subject: bin/895: ppp predictor-1 memory leak [PATCH included] Message-ID: <199512162138.QAA00570@irbs.irbs.com> Resent-Message-ID: <Pine.ULT.3.91.951216165500.10978D@ucvg.med.utah.edu>
next in thread | raw e-mail | index | archive | help
>Number: 895
>Category: bin
>Synopsis: ppp predictor-1 memory leak [PATCH included]
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Dec 16 13:40:02 PST 1995
>Last-Modified:
>Originator: John Capo
>Organization:
IRBS Engineering
>Release: FreeBSD 2.1-STABLE i386
>Environment:
>Description:
A link problem, like a silo overflow, that will cause a FCS error
results in a memory leak for each input packet and FCS failures on
all subsequent predictor-1 compressed input packets.
>How-To-Repeat:
Enable and allow predictor-1 compression
Run something that will generate considerable input to ppp
Cause a silo overflow, start Xinside for instance
>Fix:
*** pred.c.orig Mon May 29 23:50:55 1995
--- pred.c Sat Dec 16 16:27:20 1995
***************
*** 182,187 ****
--- 182,188 ----
if (len != len1) { /* Error is detected. Send reset request */
CcpSendResetReq(&CcpFsm);
pfree(bp);
+ pfree(wp);
return;
}
cp += olen - 4;
***************
*** 213,218 ****
--- 214,224 ----
proto = (proto << 8) | *pp++;
}
DecodePacket(proto, wp);
+ }
+ else
+ {
+ CcpSendResetReq(&CcpFsm);
+ pfree(wp);
}
pfree(bp);
}
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512162138.QAA00570>