Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Aug 2002 03:15:02 +1000 (EST)
From:      Bruce Evans <bde@zeta.org.au>
To:        "Andrey A. Chernov" <ache@nagual.pp.ru>
Cc:        Terry Lambert <tlambert2@mindspring.com>, David Xu <bsddiy@yahoo.com>, Julian Elischer <julian@elischer.org>, FreeBSD CURRENT <freebsd-current@FreeBSD.ORG>
Subject:   Re: cvs commit: src/sys/kern kern_sig.c (fwd)
Message-ID:  <20020813031235.O25510-100000@gamplex.bde.org>
In-Reply-To: <20020812113101.GA2089@nagual.pp.ru>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 12 Aug 2002, Andrey A. Chernov wrote:

> On Mon, Aug 12, 2002 at 04:03:31 -0700, Terry Lambert wrote:
> > "Andrey A. Chernov" wrote:
> > > On Sun, Aug 11, 2002 at 22:53:15 -0700, David Xu wrote:
> > > > following is patch for su, I can type "suspend" and stop $$ without the
> > > > problem you described, I have tested it under tcsh and bash, all works
> > > > for me.
> > >
> > > Thanx, committed.
> >
> > UGH!
> >
> > #1	License on patch is GPL
>
> Why not Microsoft?
>
> > #2	I guess now that this irritant is gone, the signals code
> > 	will remain screwed up, until some time later when you
> > 	see the shark fin above water, just before it bites
> > 	someone else?
>
> Read commit message 2 or 3 times. Meditate on each word.

Anyway, it has one blatant style bug (not 1TBS) and no explanation of
the bug, so it should not have been committed verbatim.  See another
reply for an analysis of the patch.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020813031235.O25510-100000>