Date: Sun, 22 Aug 2010 01:42:38 +0900 From: Hajimu UMEMOTO <ume@freebsd.org> To: pluknet <pluknet@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r211530 - head/sys/netinet6 Message-ID: <ygeeidrdiip.wl%ume@mahoroba.org> In-Reply-To: <AANLkTikP29Z_vO%2BF_ShsVs2wLtF-isUt_=NLZeupwnye@mail.gmail.com> References: <201008201752.o7KHqnu1044143@svn.freebsd.org> <AANLkTikP29Z_vO%2BF_ShsVs2wLtF-isUt_=NLZeupwnye@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
>>>>> On Fri, 20 Aug 2010 22:19:37 +0400
>>>>> pluknet <pluknet@gmail.com> said:
pluknet> I think it still continues to test the remain condition
pluknet> regardless of test result of the first part (!optp).
No, I don't think my fix is wrong. If the evaluation matches, the
latter should not be evaluated.
pluknet> That should work:
pluknet> - if (!optp->ip6po_pktinfo || !optp->ip6po_pktinfo->ipi6_ifindex)
pluknet> + if (optp != NULL && (!optp->ip6po_pktinfo ||
pluknet> + !optp->ip6po_pktinfo->ipi6_ifindex))
With your proposal, when optp is NULL, use_defzone doesn't set. It is
not desired thing.
Sincerely,
--
Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan
ume@mahoroba.org ume@{,jp.}FreeBSD.org
http://www.imasy.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygeeidrdiip.wl%ume>