Date: Mon, 17 Nov 2008 22:04:27 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: "M. Warner Losh" <imp@bsdimp.com> Cc: ambrisko@freebsd.org, src-committers@freebsd.org, ambrisko@ambrisko.com, jhb@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r184974 - head/sys/dev/mfi Message-ID: <20081117200427.GI90129@deviant.kiev.zoral.com.ua> In-Reply-To: <20081117.125310.-233674490.imp@bsdimp.com> References: <200811170237.mAH2bjY5088186@ambrisko.com> <200811171211.42740.jhb@freebsd.org> <20081117193541.GG90129@deviant.kiev.zoral.com.ua> <20081117.125310.-233674490.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Mon, Nov 17, 2008 at 12:53:10PM -0700, M. Warner Losh wrote:
> In message: <20081117193541.GG90129@deviant.kiev.zoral.com.ua>
> Kostik Belousov <kostikbel@gmail.com> writes:
> : diff --git a/sys/kern/imgact_aout.c b/sys/kern/imgact_aout.c
> : index f4e4614..114e0ba 100644
> : --- a/sys/kern/imgact_aout.c
> : +++ b/sys/kern/imgact_aout.c
> : @@ -82,7 +82,17 @@ struct sysentvec aout_sysvec = {
> : .sv_copyout_strings = exec_copyout_strings,
> : .sv_setregs = exec_setregs,
> : .sv_fixlimit = NULL,
> : - .sv_maxssiz = NULL
> : + .sv_maxssiz = NULL,
> : + .sv_flags = SV_NATIVE | SV_AOUT |
> : +#if defined(__i386__)
> : + SV_IA32 | SV_ILP32
> : +#elif defined(__powerpc__) || defined(__mips__)
> : + SV_ILP32
> : +#elif defined(__ia64__) || defined(__sparc64__) || defined(__amd64__)
> : + SV_LP64
> : +#else
> : +#error Choose SV_XXX flags for the platform
> : +#endif
> : };
>
> I didn't think we supported aout for mips. Also, arm is missing from
> the list :-)
Thanks.
In fact, aout works for i386 (and pc98) only. I changed the #ifdef to the
following:
diff --git a/sys/kern/imgact_aout.c b/sys/kern/imgact_aout.c
index f4e4614..78055f7 100644
--- a/sys/kern/imgact_aout.c
+++ b/sys/kern/imgact_aout.c
@@ -82,7 +82,13 @@ struct sysentvec aout_sysvec = {
.sv_copyout_strings = exec_copyout_strings,
.sv_setregs = exec_setregs,
.sv_fixlimit = NULL,
- .sv_maxssiz = NULL
+ .sv_maxssiz = NULL,
+ .sv_flags = SV_NATIVE | SV_AOUT |
+#if defined(__i386__)
+ SV_IA32 | SV_ILP32
+#else
+#error Choose SV_XXX flags for the platform
+#endif
};
static int
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)
iEYEARECAAYFAkkhzksACgkQC3+MBN1Mb4i5MACfd4UDfKXImrIYHVjEOpRzhxzI
ZakAoLiFwX5L5geI1B1IOrpdhjuKdzCV
=HPp6
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081117200427.GI90129>