Date: Thu, 16 Jan 2003 15:00:36 -0700 From: "Justin T. Gibbs" <gibbs@scsiguy.com> To: Nate Lawson <nate@root.org>, Hidetoshi Shimokawa <simokawa@freebsd.org> Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h Message-ID: <621240000.1042754436@aslan.btc.adaptec.com> In-Reply-To: <Pine.BSF.4.21.0301161007080.46845-100000@root.org> References: <Pine.BSF.4.21.0301161007080.46845-100000@root.org>
next in thread | previous in thread | raw e-mail | index | archive | help
>> Modified files: >> sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h >> Log: >> Improve memory allocation. >> - Don't use contigmalloc() and allocate page by page to avoid >> allocation failure. >> - allocate buffer by PAGE_SIZE. > > Some comments. > >> - contigfree((void *)(uintptr_t)sc->fc.sid_buf, >> - OHCI_SIDSIZE, M_DEVBUF); >> + free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF); malloced buffers are not guaranteed to be accessable by a device. Use bus dma instead. -- Justin To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?621240000.1042754436>