Date: Thu, 5 Jul 2018 23:08:39 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r336019 - in head: . usr.sbin/config Message-ID: <a177f190-cac4-6a5e-9230-e66b35a58dc0@FreeBSD.org> In-Reply-To: <CACNAnaGJw1sVjWKz0CVdpBVR5U%2BBPBcLBvKR_Z44tHJS9kTbSw@mail.gmail.com> References: <201807060111.w661B76W005640@repo.freebsd.org> <CACNAnaGJw1sVjWKz0CVdpBVR5U%2BBPBcLBvKR_Z44tHJS9kTbSw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2IThXnlo7T5MBOOVOoX2tT0kI3rCZmTA2 Content-Type: multipart/mixed; boundary="PX2dU4yd7wU53pG2iq7IingH7Uk4T4F3W"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <a177f190-cac4-6a5e-9230-e66b35a58dc0@FreeBSD.org> Subject: Re: svn commit: r336019 - in head: . usr.sbin/config References: <201807060111.w661B76W005640@repo.freebsd.org> <CACNAnaGJw1sVjWKz0CVdpBVR5U+BPBcLBvKR_Z44tHJS9kTbSw@mail.gmail.com> In-Reply-To: <CACNAnaGJw1sVjWKz0CVdpBVR5U+BPBcLBvKR_Z44tHJS9kTbSw@mail.gmail.com> --PX2dU4yd7wU53pG2iq7IingH7Uk4T4F3W Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/5/18 6:53 PM, Kyle Evans wrote: > On Thu, Jul 5, 2018 at 8:11 PM, Kyle Evans <kevans@freebsd.org> wrote: >> Author: kevans >> Date: Fri Jul 6 01:11:06 2018 >> New Revision: 336019 >> URL: https://svnweb.freebsd.org/changeset/base/336019 >> >> Log: >> config(8): De-dupe hint/env vars within a single file >> >> r335653 flipped the order in which hints/env files are concatenated = to match >> the order in which vars are processed by the kernel. This is the oth= er >> hammer to drop. >> >> Use nv(9) to de-dupe entries within a single `hint` or `env` file, u= sing the >> latest value specified for a key. This leaves some duplicates if a v= ariable >> is specified in multiple hint/env files or via `envvar` in a kernel = config, >> but the reversed order of concatenation (from r335653) makes this a >> non-issue as the latest-specified version will be seen first. >> >> This change also silently rewrote hint bits to use the same sanitiza= tion >> process that ian@ wrote for r335642. To the kernel, hints and env va= rs are >> basically the same thing through early boot, then get merged into th= e >> dynamic environment once kmem becomes available and the dynamic envi= ronment >> is created. They should be subjected to the same restrictions. >> >> libnv has been added to -legacy for the time being to support the bu= ild of >> config(8) with the new cnvlist API. >> >> Tested with: universe (11 host & 12 host) >> MFC after: 1 month >> >=20 > This seems to be causing pretty consistent config(8) failures on CI, > kernels with neither hints nor environment variables, that neither of > my universe builds nor any of my post-commit builds can reproduce. Can > anyone else reproduce these failures that might be willing to give me > a hint as to what kind of setup causes this? >=20 > 01:47:58 cd /usr/src/sys/arm/conf; > PATH=3D/usr/obj/usr/src/arm.armv7/tmp/legacy/usr/sbin:/usr/obj/usr/src/= arm.armv7/tmp/legacy/usr/bin:/usr/obj/usr/src/arm.armv7/tmp/legacy/bin:/u= sr/obj/usr/src/arm.armv7/tmp/usr/sbin:/usr/obj/usr/src/arm.armv7/tmp/usr/= bin:/sbin:/bin:/usr/sbin:/usr/bin > config -d /usr/obj/usr/src/arm.armv7/sys/GENERIC -I > '/usr/src/sys/arm/conf' '/usr/src/sys/arm/conf/GENERIC' > 01:47:58 config: /usr/src/sys/arm/conf/GENERIC: No error: 0 >=20 I've seen this error with broken ABI. The -I${SRCTOP}/sys on the config build may be contributing to the problem since sys/stat.h is ino64 and the builder may not be. Really should not be bringing in the source sys/ directory for any of the early host tool phases. There's some hack patterns to bring in a limited amount of headers but in this case the headers should be getting staged somewhere already. Note legacy: ${MAKE} DIRPRFX=3D${_tool}/ DESTDIR=3D${WORLDTMP}/legacy includes; \ So -IWORLDTMP/legacy/sys should find the nv headers. This is already included via: tools/build/mk/Makefile.boot:CFLAGS+=3D -I${WORLDTMP}/legacy/usr/includ= e Which is brought in for bootstrap-tools though via: MAKEFLAGS=3D"-m ${.CURDIR}/tools/build/mk ${.MAKEFLAGS}" --=20 Regards, Bryan Drewery --PX2dU4yd7wU53pG2iq7IingH7Uk4T4F3W-- --2IThXnlo7T5MBOOVOoX2tT0kI3rCZmTA2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAls/B2cACgkQNddxu25G l8+XRgf/UjXK5BTC9nTpT8fAYLTpD0ktW98/PJRXCK9WLqis9weE7X6FKaVC8urb 5evAWS5TOLhAjoqKUCBqLhReQ/GuIPQRwQsqQq04/fjeDI5CLampLzqQYb3hSffU 8mgwx0azuDSa9RSeXCFU2pQlr5DaufGFToS2ybavDMgafC3Nzr1eLLnuryYXzBy+ QZgGIlx52O01q6Y3CLXrNpQat7iHDeWSYX8V3TMMxy0u3wzynVzqnCn6sasgPbjl Zya5Py0ggv8G4cowQrzFes5eKaQLs1zb9+6L+wkUT1RT+NtG1VAQnWgHmR11IPZx yty+HbaZK7MB/Owz1iGq3zXVEuu+UA== =l/ct -----END PGP SIGNATURE----- --2IThXnlo7T5MBOOVOoX2tT0kI3rCZmTA2--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a177f190-cac4-6a5e-9230-e66b35a58dc0>