Date: Thu, 15 Jan 2015 12:05:14 -0800 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: John Baldwin <jhb@freebsd.org>, Warner Losh <imp@bsdimp.com>, Justin Hibbits <chmeeedalf@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>, Warner Losh <imp@freebsd.org> Subject: Re: svn commit: r277163 - head/sys/dev/cardbus Message-ID: <54B81D7A.6080502@freebsd.org> In-Reply-To: <54B80C46.2010409@FreeBSD.org> References: <201501140541.t0E5fV00070032@svn.freebsd.org> <54B67BC9.70904@FreeBSD.org> <20150114073246.74c159df@zhabar.attlocal.net> <8CB7CB29-FBFF-4850-A226-4FA5B6BF6A87@bsdimp.com> <54B7E8EA.1090509@freebsd.org> <54B80C46.2010409@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 01/15/15 10:51, John Baldwin wrote: > On 1/15/15 11:20 AM, Nathan Whitehorn wrote: >> On 01/14/15 16:07, Warner Losh wrote: >>>> On Jan 14, 2015, at 8:32 AM, Justin Hibbits <chmeeedalf@gmail.com> >>>> wrote: >>>> >>>> On Wed, 14 Jan 2015 09:23:05 -0500 >>>> John Baldwin <jhb@FreeBSD.org> wrote: >>>> >>>>> On 1/14/15 12:41 AM, Warner Losh wrote: >>>>>> Author: imp >>>>>> Date: Wed Jan 14 05:41:31 2015 >>>>>> New Revision: 277163 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/277163 >>>>>> >>>>>> Log: >>>>>> Add a rather obnoxious warning if you don't have NEW_PCIB defined >>>>>> since it's a total crap shoot if things will work. >>>>> Should we just make it a #error instead? (Some day I hope to have >>>>> NEW_PCIB enabled by default and remove the old code. Will take a >>>>> while to get there for the generic PCI code, but cardbus is probably >>>>> only used on x86 so that would be fine.) >>>>> >>>> Also powerpc, but NEW_PCIB is default there as well. >>> PowerPC doesn’t seem to defined the bus number resources. >>> >>> Warner >>> >> Which ones? >> -Nathan > PCI_RES_BUS. > > https://svnweb.freebsd.org/base?view=revision&revision=261790 > > I misspoke about it being in the nexus. On x86 it is done in the ACPI > Host-PCI bridge drivers (since those have a _SEG method to know which > PCI domain/segment/hose the child bus belongs to). You could > conceivably do it higher up at whatever level understands which PCI > domain a given Host-PCI bridge lives in. > > If you only ever support a single PCI domain, you could just place it in > the nexus with a hardcoded domain arg of 0 to the pci_domain_*() functions. > Most PPC systems have at least two and usually more PCI domains. I'll take a look at adding this. -Nathan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54B81D7A.6080502>