Date: Thu, 16 Jan 2003 17:43:00 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: Sam Leffler <sam@errno.com> Cc: "Justin T. Gibbs" <gibbs@scsiguy.com>, Nate Lawson <nate@root.org>, Hidetoshi Shimokawa <simokawa@FreeBSD.org>, cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/firewire firewire.c fwdev.c fwohci.c fwohcivar.h Message-ID: <Pine.NEB.3.96L.1030116173810.3721X-100000@fledge.watson.org> In-Reply-To: <20e801c2bdad$770d56f0$5a557f42@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 16 Jan 2003, Sam Leffler wrote: > > >> - contigfree((void *)(uintptr_t)sc->fc.sid_buf, > > >> - OHCI_SIDSIZE, M_DEVBUF); > > >> + free((void *)(uintptr_t)sc->fc.sid_buf, M_DEVBUF); > > > > malloced buffers are not guaranteed to be accessable by a device. > > Use bus dma instead. > > New drivers should use bus_dma. I recently hit an issue like this with > jumbo mbufs not being handled by the bge driver because it doesn't use > bus dma. Yeah, agreed. mux, tmm, and others have been doing a nice job of pushing over drivers to busdma, but we basically need to disallow any non-busdma drivers from being added from now on. A reasonable strategy is that existing drivers must be converted by current maintainers, if any, by 5.1. If there's no maintainer, we pick them up more gradually. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1030116173810.3721X-100000>