Date: Thu, 25 Oct 2018 21:44:24 -0600 From: Warner Losh <imp@bsdimp.com> To: Jan Beich <jbeich@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r339563 - in head: . share/man/man4 sys/conf sys/dev/joy sys/modules sys/modules/joy sys/sys tools/kerneldoc/subsys Message-ID: <CANCZdfrQjZWun6w2qvhZZ7-%2B_tvOsVwOjeqqPHq9mOHVYCd76A@mail.gmail.com> In-Reply-To: <zhv1-1j29-wny@FreeBSD.org> References: <201810220234.w9M2Y0Wk043492@repo.freebsd.org> <mur3-tkpo-wny@FreeBSD.org> <CANCZdfre3F8rOsc5Z96zse7vRe%2B6As3kqE01rpChZkNQTA8QBQ@mail.gmail.com> <zhv1-1j29-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 25, 2018 at 9:30 PM Jan Beich <jbeich@freebsd.org> wrote: > Warner Losh <imp@bsdimp.com> writes: > > > On Wed, Oct 24, 2018 at 9:42 AM Jan Beich <jbeich@freebsd.org> wrote: > > > >> Warner Losh <imp@FreeBSD.org> writes: > >> > >> > Author: imp > >> > Date: Mon Oct 22 02:34:00 2018 > >> > New Revision: 339563 > >> > URL: https://svnweb.freebsd.org/changeset/base/339563 > >> > > >> > Log: > >> > Remove joy(4) driver. > >> > > >> > This driver was marked as gone in 12. We're at 13 now. Remove it. > >> > Data from nycbug's dmesg cache shows only one potential user, > >> > suggesting it never was used much. > >> > > >> > RelNotes: yes > >> > Differential Revision: https://reviews.freebsd.org/D17629 > >> > >> Breaking userland API but not bothering with an exp-run or bumping > >> __FreeBSD_version. > >> Is the following the pointy hat you were looking for? > >> > >> > >> > https://forums.freebsd.org/threads/graphics-freeglut-fails-to-build-sys-joystick-h-not-found.68002/ > > > > > > Your tone is not acceptable. Please try again, only this time with the > > required level of professionalism. I'm not an idiot, and you will treat > me > > with respect. > > Apologies for the snide remark. I've expected someone with ports/ commit > bit > to be a bit more careful. > To be honest, I've never been burned before. It has been a learning lession. > > This driver was flagged for removal in 12 ages ago and the port failed to > > update to take that deprecation into account. > > Not sure what "ages ago" refers to when not even 1 year passed since > r328523. > Neither joy(4) manpage mentioned deprecation nor > __attribute__((deprecated)) > was used. Maintainers of consumers aren't necessarily joy(4) users. > But only joy(4) generates events and supports things described here. And joy(4) hasn't been relevant in this century. I thought this was totally safe. And I've not ever used / seen __attribute__((deprecated)). I will have to start using it. > Was joy(4) deprecation announced on the public mailing lists? For some > reason, > I can't easily find it in the archives. > I thought I had, but I'm not seeing it in my archives. > > You can use the bump to 1300000 as the version to fix it. I didn't bump > the > > revision because it wasn't needed. > > poudriere won't force rebuild everything if __FreeBSD_version doesn't > change. > Right. OK. I was not aware of that. > Expect silence from pkg-fallout@ until the next bump. > There was one earlier today. > > http://www.ipv6proxy.net/go.php?u=http://beefy12.nyi.freebsd.org/data/latest-per-pkg/sdl/1.2.15_12,2/head-amd64-default.log > > http://www.ipv6proxy.net/go.php?u=http://beefy12.nyi.freebsd.org/data/latest-per-pkg/plib/1.8.5_7/head-amd64-default.log > > vs. > > > http://beefy8.nyi.freebsd.org/data/latest-per-pkg/sdl/1.2.15_12,2/head-armv6-default.log > > http://beefy8.nyi.freebsd.org/data/latest-per-pkg/plib/1.8.5_7/head-armv6-default.log Yea, that's more extensive than I'd expected. > I posted a patch to the port that makes it compile for me to that thread. > > If there's confirmation that it works, i'll work with x11@freebsd.org to > > get it pushed in. Or just push it in myself since I'm on that list and > I'm > > a ports committer. > > https://codesearch.debian.net/search?q=sys/joystick.h could've been used > to guess a few consumers before pkg-fallout@ complains. > True. Most of them are bogus, but many are not. Given the number, I'm going to add sys/joystick.h back and bump the __FreeBSD_version and learn from my mistake. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrQjZWun6w2qvhZZ7-%2B_tvOsVwOjeqqPHq9mOHVYCd76A>