Date: Thu, 14 May 1998 08:51:42 +0900 From: Jun-ichiro itojun Itoh <itojun@itojun.org> To: "Matthew N. Dodd" <winter@jurai.net> Cc: freebsd-net@FreeBSD.ORG Subject: Re: WIDE/KAMI IPv6 Message-ID: <25223.895103502@coconut.itojun.org> In-Reply-To: winter's message of Wed, 13 May 1998 15:24:36 -0400. <Pine.BSF.3.96.980513151054.17033W-100000@sasami.jurai.net>
next in thread | previous in thread | raw e-mail | index | archive | help
>Ok, for kicks I've been reviewing the KAMI and INRIA IPv6 stuff and have a >few questions/comments on the KAMI code I've seen so far. >What kind of crack prompted the need to do this: >+ #ifdef INET6 >+ in6_ifattach(&sc->arpcom.ac_if, IN6_IFT_802, >+ (caddr_t)sc->arpcom.ac_enaddr, 0); >+ #endif /* INET6 */ >+ >in -every- 'supported' network driver's XXinit function. The above claim is not true. You'll need to have the above line in attach routine for *pccard* network drivers. For normal interfaces, in6_ifattach() is called from in6_ifattach_802(), which is called from ip6_init2() in sys/netinet6/ip6_input.c. >Is there any reason this code does not belong in ifattach() or >ether_ifattach()? in6_ifattach() must be called after *all* the initialization for the interface. If we can guarantee that ether_ifattach() is called in the very last part of xxattach(), we can bury in6_ifattach() call into ether_ifattach. At this moment there's no such guarantee so we have added in6_ifattach() into attach routine, for pccard network cards. itojun To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25223.895103502>