Date: Wed, 14 Mar 2018 08:21:20 -0600 From: Ian Lepore <ian@freebsd.org> To: Wojciech Macek <wma@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r330925 - in head/sys: conf powerpc/powernv Message-ID: <1521037280.84937.285.camel@freebsd.org> In-Reply-To: <201803140920.w2E9K3mn019118@repo.freebsd.org> References: <201803140920.w2E9K3mn019118@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 2018-03-14 at 09:20 +0000, Wojciech Macek wrote: > Author: wma > Date: Wed Mar 14 09:20:03 2018 > New Revision: 330925 > URL: https://svnweb.freebsd.org/changeset/base/330925 > > Log: > PowerNV: Fix I2C to compile if FDT is disabled > > Submitted by: Wojciech Macek <wma@semihalf.com> > Obtained from: Semihalf > Sponsored by: IBM, QCM Technologies > This seems to be a nonsensical commit. What's the point of compiling in a driver which is hard-coded to return failure from the probe and attach routines? The pre-change code seemed more correct: the driver can only possibly work if FDT/OFW data is available, so only compile it in when that option is in effect. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1521037280.84937.285.camel>