Date: Fri, 27 Nov 2009 15:12:42 +0200
From: Kostik Belousov <kostikbel@gmail.com>
To: Joe Marcus Clarke <marcus@freebsd.org>
Cc: threads@freebsd.org
Subject: Re: [PATCH] Add missing pthread_condattr_{init, destroy} stubs to libc
Message-ID: <20091127131242.GA2368@deviant.kiev.zoral.com.ua>
In-Reply-To: <1259298918.1608.19.camel@shumai.marcuscom.com>
References: <1259298918.1608.19.camel@shumai.marcuscom.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --]
On Fri, Nov 27, 2009 at 12:15:18AM -0500, Joe Marcus Clarke wrote:
> I would like permission to commit this patch which adds missing
> pthread_condattr_{init,destroy} symbols to libc. I think I did the
> symbol addition correctly (and it seems to work). Without this, the
> weak symbols added in the libpthread-stubs port conflict with those in
> libthr, and applications with use these symbols can crash.
>
> I have temporarily hacked libpthread-stubs to fix this, but I really
> feel these stubs should be added to libc. I've also copied kib as he
> has been kind enough to review my work in the past. Thanks.
>
> http://www.marcuscom.com/downloads/stubs.diff
It is FBSD_1.2 version that we use for symbols added after HEAD become
CURRENT-9.
I think that you shall change lib/libc/libc_private.h, adding
corresponding definitions for the PJT_CONDATTR_DESTROY/PJT_CONDATTR_INIT
indexes.
Is the patch buildable ?
Interesting question is whether these changes are mergeable to the
stable branch. Possibly yes, if we declare that rtld/libc/libthr shall
be built from the consistent source snapshot.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)
iEYEARECAAYFAksP0EoACgkQC3+MBN1Mb4hTNwCgpNcCKfhO4bbUXxt3Kv2wfm/W
c6UAoNR/VPVfGKxjG5tN3xxx4pDDkmIK
=qujH
-----END PGP SIGNATURE-----
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091127131242.GA2368>