Date: Fri, 25 Oct 2013 11:03:16 +0100 From: "Steven Hartland" <killing@multiplay.co.uk> To: "Dimitry Andric" <dimitry@andric.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r257109 - head/contrib/llvm/tools/clang/tools/driver Message-ID: <2DE0EA95F6944DB28D4B2F03EEF582F8@multiplay.co.uk> References: <201310250909.r9P990nk083926@svn.freebsd.org> <BFE9444E-33F8-438E-AC49-FF20101AECF2@andric.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 25 Oct 2013, at 11:09, Steven Hartland <smh@freebsd.org> wrote: > > Author: smh > > Date: Fri Oct 25 09:09:00 2013 > > New Revision: 257109 > > URL: http://svnweb.freebsd.org/changeset/base/257109 > > > > Log: > > Add clang-CC and CC to list of hints allowing clang to identify its operating > > mode as c++ instead of defaulting to c for the binary names CC and clang-CC. > > > > This fixes builds that use cmake, which automatically sets CXX to > > /usr/bin/CC by default. > > Huh, I’ve never seen that behavior with cmake? At least, not with any > fairly recent version... > > Anyway, I do not really agree with this change, and I would rather just > get rid of the /usr/bin/CC link instead. Build scripts and Makefiles > should use "c++" instead, which is the standard name for a C++ compiler. > > Note that you also introduce yet another change from upstream... :-/ As discussed on IRC while I agree removing CC is possibly the better fix moving forward, I think removing /usr/bin/CC has quite a bit more risk, especially at this stage in the release phase of 10. Given this I would suggest this for now we make the change to clang and then possibly look at remove CC at a later date. If there's no objections I intend to ask re@ for permission to MFC this for the release of 10, so if there are any objections please do speak up :) Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2DE0EA95F6944DB28D4B2F03EEF582F8>