Date: Sat, 20 Sep 2025 00:47:40 GMT From: Adrian Chadd <adrian@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: a58f30788070 - main - [iwn] Don't originate NULL data frames in net80211 Message-ID: <202509200047.58K0leL1017103@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=a58f307880700fff7646416101c301e4d1784bfb commit a58f307880700fff7646416101c301e4d1784bfb Author: Adrian Chadd <adrian@FreeBSD.org> AuthorDate: 2025-08-27 20:06:55 +0000 Commit: Adrian Chadd <adrian@FreeBSD.org> CommitDate: 2025-09-20 00:46:32 +0000 [iwn] Don't originate NULL data frames in net80211 Don't originate null data frames in net80211; leave that up to the iwn firmware. This should fix a bunch of cases where we're seeing out of sequence 802.11n aggregation data packets because net80211 power management stuff was triggering NULL data frames when we don't need them and messing up the firmware / ring buffer sequence number space. Differential Revision: https://reviews.freebsd.org/D52299 Locally tested: * 6205, STA mode --- sys/dev/iwn/if_iwn.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/dev/iwn/if_iwn.c b/sys/dev/iwn/if_iwn.c index 6270de3627e6..a949103f20d4 100644 --- a/sys/dev/iwn/if_iwn.c +++ b/sys/dev/iwn/if_iwn.c @@ -586,6 +586,8 @@ iwn_attach(device_t dev) /* Driver / firmware assigned sequence numbers */ ic->ic_flags_ext |= IEEE80211_FEXT_SEQNO_OFFLOAD; + /* Don't originate null data frames in net80211 */ + ic->ic_flags_ext |= IEEE80211_FEXT_NO_NULLDATA; /* Read MAC address, channels, etc from EEPROM. */ if ((error = iwn_read_eeprom(sc, ic->ic_macaddr)) != 0) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202509200047.58K0leL1017103>