Date: Sat, 31 Aug 1996 00:49:35 +0800 From: Peter Wemm <peter@spinner.DIALix.COM> To: =?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= (Andrey A. Chernov) <ache@nagual.ru> Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org Subject: Re: cvs commit: src/gnu/lib/libreadline Makefile Message-ID: <199608301649.AAA02200@spinner.DIALix.COM> In-Reply-To: Your message of "Fri, 30 Aug 1996 14:30:44 %2B0400." <199608301030.OAA00587@nagual.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
=?KOI8-R?Q?=E1=CE=C4=D2=C5=CA_=FE=C5=D2=CE=CF=D7?= wrote: > > peter 96/08/29 19:13:09 > > > > Modified: gnu/lib/libreadline Makefile > > Log: > > cmp -s || install -c ==> install -C > > Add -DHAVE_UNISTD_H -DHAVE_STDLIB_H to get these files > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > Please, back out this change, they already defined in config.h The following files dont include config.h or rldefs.h at all: funmap.c history.c isearch.c tilde.c xmalloc.c (rldefs.h #include's config.h as well) Those files do test the HAVE_x_H defines to #include unistd.h or stdlib.h. The choice was add the defines to the CFLAGS, or change those files and diverge from their gnu counterparts. Since the Makefile is under our control, but the source is 3rd party, it made sense to me at the time to change the Makefile. > -- > Andrey A. Chernov > <ache@nagual.ru> > http://www.nagual.ru/~ache/ Cheers, -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199608301649.AAA02200>