Date: Sun, 25 Feb 2018 16:54:44 -0700 From: Warner Losh <imp@bsdimp.com> To: Alan Somers <asomers@freebsd.org> Cc: Steve Wills <swills@freebsd.org>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328612 - head/lib/libc/stdlib Message-ID: <CANCZdfoQ3itkqdemDSESQsw=EePf-MoV%2BKv9F4rQYGrGxNfs6A@mail.gmail.com> In-Reply-To: <CAOtMX2iUr_5aZY_91MOobRfxgfVGztLEbR8vPC5dk4P=ALzNjw@mail.gmail.com> References: <201801310305.w0V35EU4090569@repo.freebsd.org> <f756b897-0b97-e033-a007-0aa88b0baae6@FreeBSD.org> <CANCZdfp=A4cem5h26NxE-D9%2BiOyOLc6JU8NzdPcByts-dZ=A6g@mail.gmail.com> <CAOtMX2iUr_5aZY_91MOobRfxgfVGztLEbR8vPC5dk4P=ALzNjw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Sorry for top posting...
I fixed this with r328768
Author: imp <imp@ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f>
Date: Fri Feb 2 05:04:43 2018 +0000
The routines defined in comparedf2 and comparesf2 are defined in libc
for softfloat mips. No need to include them here.
lib/libcompiler_rt/Makefile.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
John Baldwin says this may be a bogus fix, but we've come to no better one
in the interim. He's not wrong to say this is bogus, but it does fix the
immediate compile issue.
Warner
On Sun, Feb 25, 2018 at 7:52 AM, Alan Somers <asomers@freebsd.org> wrote:
> I'm seeing the same error during the build of usr.sbin/nologin for
> riscv.riscv64sf. Has anybody figured out a solution yet?
>
> On Thu, Feb 1, 2018 at 9:09 PM, Warner Losh <imp@bsdimp.com> wrote:
>
>>
>>
>> On Thu, Feb 1, 2018 at 8:34 PM, Steve Wills <swills@freebsd.org> wrote:
>>
>>> This, somehow, seems to have broken the mips64 build:
>>>
>>> https://ci.freebsd.org/job/FreeBSD-head-mips64-build/216/consoleFull
>>>
>>> The previous rev works.
>>>
>>
>> This breaks devd, of all things, with
>>
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
>> function `__gedf2':
>> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:96: multiple
>> definition of `__gedf2'
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(gedf2.o):/us
>> r/src/lib/libc/softfloat/gedf2.c:18: first defined here
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
>> function `__eqdf2':
>> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:126: multiple
>> definition of `__eqdf2'
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(eqdf2.o):/us
>> r/src/lib/libc/softfloat/eqdf2.c:18: first defined here
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
>> function `__ltdf2':
>> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:131: multiple
>> definition of `__ltdf2'
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(ltdf2.o):/us
>> r/src/lib/libc/softfloat/ltdf2.c:18: first defined here
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
>> function `__nedf2':
>> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:136: multiple
>> definition of `__nedf2'
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(nedf2.o):/us
>> r/src/lib/libc/softfloat/nedf2.c:18: first defined here
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libgcc.a(comparedf2.o): In
>> function `__gtdf2':
>> /usr/src/contrib/compiler-rt/lib/builtins/comparedf2.c:141: multiple
>> definition of `__gtdf2'
>> /usr/obj/usr/src/mips.mips64/tmp/usr/lib/libc.a(gtdf2.o):/us
>> r/src/lib/libc/softfloat/gtdf2.c:18: first defined here
>>
>> undefined.... devd doesn't even use strtodl.
>>
>> (looks like the code to associate make output with the right commands is
>> broken, since I had to dig for it.
>>
>> Warner
>>
>>
>>> Steve
>>>
>>>
>>> On 01/30/2018 22:05, Warner Losh wrote:
>>>
>>>> Author: imp
>>>> Date: Wed Jan 31 03:05:14 2018
>>>> New Revision: 328612
>>>> URL: https://svnweb.freebsd.org/changeset/base/328612
>>>>
>>>> Log:
>>>> Move strtold wrapper from strtol.c to its own strtold.c. This code
>>>> was written by theraven@ (David Chisnall) entirely, there's no
>>>> original Berkeley code left here so just copy his copyright over.
>>>>
>>>>
>>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoQ3itkqdemDSESQsw=EePf-MoV%2BKv9F4rQYGrGxNfs6A>