Date: Sat, 2 Feb 2008 19:33:44 +0000 From: Ceri Davies <ceri@submonkey.net> To: Hartmut Brandt <hartmut.brandt@dlr.de> Cc: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Dag-Erling Smorgrav <des@FreeBSD.org>, "Simon L. Nielsen" <simon@FreeBSD.org> Subject: Re: cvs commit: src/etc/periodic/security 100.chksetuid Message-ID: <20080202193344.GI6064@submonkey.net> In-Reply-To: <47A49FBF.2010301@dlr.de> References: <200802021227.m12CRcZ9008161@repoman.freebsd.org> <20080202145321.GH6064@submonkey.net> <20080202160451.GD11904@zaphod.nitro.dk> <47A49FBF.2010301@dlr.de>
next in thread | previous in thread | raw e-mail | index | archive | help
--APvmIexg9DiduZOF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 02, 2008 at 05:52:15PM +0100, Hartmut Brandt wrote: > Simon L. Nielsen wrote: >> On 2008.02.02 14:53:21 +0000, Ceri Davies wrote: >>> On Sat, Feb 02, 2008 at 12:27:38PM +0000, Dag-Erling Smorgrav wrote: >>>> des 2008-02-02 12:27:38 UTC >>>>=20 >>>> FreeBSD src repository >>>>=20 >>>> Modified files: >>>> etc/periodic/security 100.chksetuid Log: >>>> Rewrite to consume significantly less memory, by using find -s inste= ad of >>>> find | sort. As a bonus, this simplifies the logic considerably. A= lso >>>> remove the bogus "overruning the args to ls" comment and the corresp= onding >>>> "-n 20" argument to xargs; the whole point with xargs is precisely t= hat it >>>> knows how large the argument list can safely get. >>> Why use xargs at all? The "-exec ls -liTd {} +" primary would do the >>> same thing. >>=20 >> You would end up executing ls a lot more times with the extra overhead >> for fork() etc. per file. >=20 > I think "-exec ... {} +" collects as much arguments before executing just= =20 > as xargs does. This is different from "-exec ... {} ;" which execs for ea= ch=20 > argument. Exactly my point, yes. Ceri --=20 That must be wonderful! I don't understand it at all. -- Moliere --APvmIexg9DiduZOF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFHpMWYocfcwTS3JF8RAgtLAKCGvjIWu/DEa+LauxQqfRTKjhyqFQCcDpTY qdlnJlnIpaW5Wk4EwcAUFec= =ZQDm -----END PGP SIGNATURE----- --APvmIexg9DiduZOF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080202193344.GI6064>