Date: Sat, 1 Mar 2003 18:36:42 -0500 From: Barney Wolff <barney@pit.databus.com> To: Jens Rehsack <rehsack@liwing.de> Cc: Juli Mallett <jmallett@FreeBSD.ORG>, current@FreeBSD.ORG Subject: Re: PATCH: type errors in src-tree Message-ID: <20030301233642.GA64401@pit.databus.com> In-Reply-To: <3E612F7F.1090002@liwing.de> References: <3E5EA13E.9020208@liwing.de> <3E60F1CF.2030400@liwing.de> <20030301155546.A39174@FreeBSD.org> <3E612F7F.1090002@liwing.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 01, 2003 at 11:09:03PM +0100, Jens Rehsack wrote: > ... > >>- u_char **bufp; > >>+ caddr_t *bufp; > ... > Of course. Very often in ilmid.c the type caddr_t was used, and nearly > the same count of 'const char *'s was used. I've searched the include > files for caddr_t (core address) and found it defined as 'char *', so I > decided to used commonly caddr_t - maybe later I check which of them > could be changed into 'c_caddr_t' for being const. But You can of couse > replace all 'caddr_t' which 'char *'. Shouldn't we care about u_char vs char? On some machines it matters, and on all machines compilers tend to notice and generate warnings. -- Barney Wolff http://www.databus.com/bwresume.pdf I'm available by contract or FT, in the NYC metro area or via the 'Net. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030301233642.GA64401>