Date: Thu, 8 Aug 2019 05:04:13 +0800 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Mark Johnston <markj@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350512 - head/tests/sys/kern Message-ID: <CAKBkRUwkQB6d=xyYMGo44XpAR36LRq2VrMokoZNv4yZUakZ2iQ@mail.gmail.com> In-Reply-To: <20190807202732.GD1377@raichu> References: <201908011819.x71IJG0M076399@repo.freebsd.org> <20190807202732.GD1377@raichu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Aug 8, 2019 at 4:27 AM Mark Johnston <markj@freebsd.org> wrote: > > On Thu, Aug 01, 2019 at 06:19:16PM +0000, Li-Wen Hsu wrote: > > Author: lwhsu > > Date: Thu Aug 1 18:19:16 2019 > > New Revision: 350512 > > URL: https://svnweb.freebsd.org/changeset/base/350512 > > > > Log: > > Only skip test cases sometimes failing in CI when they are running in CI > > > > Suggested by: jhb > > Sponsored by: The FreeBSD Foundation > > This seems to break running the tests manually; atf dies because the > "ci" variable is not defined. I have to use an invocation like this to > avoid that: > > $ kyua -v test_suites.FreeBSD.ci=false test ptrace_test > > I suspect that share/mk/suite.test.mk needs to be augmented somehow to > set this variable to "false" by default, so that the CI infrastructure > can override that. Thanks for catching this! I feel that the better approach is using function that gets this variable with default value, for keeping things simple. Best, Li-Wen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUwkQB6d=xyYMGo44XpAR36LRq2VrMokoZNv4yZUakZ2iQ>