Date: Mon, 14 Jan 2002 20:09:34 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Alfred Perlstein <alfred@FreeBSD.org>, <cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/contrib/ipfilter/ipsend sock.c Message-ID: <20020114195528.T5016-100000@gamplex.bde.org> In-Reply-To: <20020114103437.A85961@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 14 Jan 2002, Ruslan Ermilov wrote: > On Mon, Jan 14, 2002 at 04:20:23PM +1100, Bruce Evans wrote: > > On Sun, 13 Jan 2002, Alfred Perlstein wrote: > > >... > > > Log: > > > add queue.h, now needed for file.h > > >... > > > > This is file.h's responsibility. file.h already includes queue.h, so > > the problem must be elsewhere. Anyway, it is a bug if changes of > > kernel implementation details affect prerequisites in applications. > > > Moving <sys/queue.h> from after <sys/_mutex.h> to before <sys/_lock.h> > in file.h should fix the problem. Right. <sys/_lock.h> and <sys/_mutex.h> use the queue macros and don't include <sys/queue.h>, so headers that include them must include <sys/queue.h> first. When fixing this, please also remove the new bogus include of <sys/types.h> from <sys/file.h>. <sys/types.h> has been a prerequisite for <sys/file.h> in the kernel for at least 10 years, so everything that included <sys/file.h> already included this prerequisite (usually indirectly via <sys/param.h>). Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020114195528.T5016-100000>