Date: Fri, 27 Jun 2025 18:23:08 -0700 From: Gleb Smirnoff <glebius@freebsd.org> To: Alan Somers <asomers@freebsd.org>, Damin Rido <rido@freebsd.com> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0726c6574f88 - main - sockstat: Add automatic column sizing and remove -w option Message-ID: <aF9D_NPdWAT20cB2@cell.glebi.us> In-Reply-To: <202506271559.55RFxWdm024724@gitrepo.freebsd.org> References: <202506271559.55RFxWdm024724@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, On Fri, Jun 27, 2025 at 03:59:32PM +0000, Alan Somers wrote: A> commit 0726c6574f889507e5030173bf4c82c80911394d A> Author: Damin Rido <rido@FreeBSD.com> A> AuthorDate: 2025-06-12 09:12:49 +0000 A> Commit: Alan Somers <asomers@FreeBSD.org> A> CommitDate: 2025-06-27 15:54:41 +0000 A> A> sockstat: Add automatic column sizing and remove -w option A> A> Refactor sockstat to dynamically size table columns based on content. A> This eliminates the need for the -w option, which is now ignored A> for backwards compatibility. A> A> Numeric columns are now right-aligned for improved readability; A> previously, they were left-aligned. A> A> Unknown fields are now consistently shown as "??" instead of a mix A> of "", "?", and "?" for output uniformity. A> A> Sponsored by: Google, LLC (GSoC 2025) A> MFC after: 2 weeks A> Reviewed by: asomers A> Pull Request: https://github.com/freebsd/freebsd-src/pull/1720 A> --- A> usr.bin/sockstat/sockstat.1 | 6 +- A> usr.bin/sockstat/sockstat.c | 622 +++++++++++++++++++++++++++----------------- A> 2 files changed, 392 insertions(+), 236 deletions(-) The commit message looks promising, but so far the output of the program that I use daily has been made much worsr :( First, there is a spurious second newline on every line. Even after the header line! How could that pass through minimal testing? Second, the default output now just inserts a huge whitespace "column" in the middle of the list, making it extermely wide. Note, that before this change the default output was fitting into 80 char terminal. Now it is not fitting and without any good reason to do so. I really would prefer this reverted and re-tested by a wider audience before pushing it back in. -- Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?aF9D_NPdWAT20cB2>