Date: Tue, 10 Oct 2023 01:58:45 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271750] setusercontext(): Apply user '.login_conf' on process' effective uid being set Message-ID: <bug-271750-227-m1P0O9Olik@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-271750-227@https.bugs.freebsd.org/bugzilla/> References: <bug-271750-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271750 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D892654fe9b5a9115815c30a423b8db471= 85aebbd commit 892654fe9b5a9115815c30a423b8db47185aebbd Author: Olivier Certner <olce.freebsd@certner.fr> AuthorDate: 2023-05-30 16:35:08 +0000 Commit: Ed Maste <emaste@FreeBSD.org> CommitDate: 2023-10-10 01:47:10 +0000 setusercontext(): Apply personal settings only on matching effective UID Commit 35305a8dc114 (r211393) added a check on whether 'uid' was equal to getuid() before calling setlogincontext(). Doing so still allows a setuid program to apply resource limits and priorities specified in a user-controlled configuration file ('~/.login_conf') where a non-setuid program could not. Plug the hole by checking instead that the process' effective UID is the target one (which is likely what was meant in the initial commit). PR: 271750 Reviewed by: kib, des MFC after: 2 weeks Sponsored by: Kumacom SAS Differential Revision: https://reviews.freebsd.org/D40351 lib/libutil/login_class.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271750-227-m1P0O9Olik>