Date: Tue, 21 May 2019 09:54:14 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net> To: Brooks Davis <brooks@freebsd.org> Cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org Subject: Re: svn commit: r348012 - in stable/12: libexec/rc sbin/ifconfig share/man/man5 tools/tools/tinybsd/conf/firewall/etc usr.sbin/jail Message-ID: <201905211654.x4LGsEAR080015@gndrsh.dnsmgr.net> In-Reply-To: <20190521164033.GG68351@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Mon, May 20, 2019 at 06:30:26PM -0700, Rodney W. Grimes wrote: > > > Author: brooks > > > Date: Mon May 20 21:33:22 2019 > > > New Revision: 348012 > > > URL: https://svnweb.freebsd.org/changeset/base/348012 > > > > > > Log: > > > MFC r347963: > > > > > > Change ed(4), ep(4), and fxp(4) examples to em(4). > > > > > > ed(4) and ep(4) will be removed in FreeBSD 13. fxp(4) remains > > > popular in older systems, but isn't as future proof as em(4). > > > > > > Reviewed by: bz, jhb > > > Differential Revision: https://reviews.freebsd.org/D20311 > > > > Though this made since to me in head, it does not in stable, > > as you may of just broke someones running system when they > > do a merge master if they happened to of depended on the very > > long standing defaults of fxp that are NOT in comment lines > > below. > > I didn't really thing about fact these are actual defaults. We should > comment out or remove most/all of these out. They are a terrible idea... > > I've reverted in r348055. Thank you, and I fully agree on the terrible idea, perhaps look at rewritting the effected code so that it errors out or at least warns if these values are not set, then remove the setting of them in etc/default/rc.conf would be one way to clean this up. > -- Brooks -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905211654.x4LGsEAR080015>