Date: Sat, 28 Jun 2025 04:04:33 +0200 From: Michael Tuexen <tuexen@FreeBSD.org> To: Charlie Li <vishwin@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 89f6eb0a61cb - main - tcp: restrict the contents of tcp_timer.h to the kernel context Message-ID: <BDD29F9A-1254-4631-B804-E10A523A8CC4@FreeBSD.org> In-Reply-To: <b01738c4-a780-4553-bb6e-718e9fba18cd@freebsd.org> References: <202506261609.55QG9odv049208@gitrepo.freebsd.org> <b01738c4-a780-4553-bb6e-718e9fba18cd@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 28. Jun 2025, at 00:34, Charlie Li <vishwin@FreeBSD.org> wrote: >=20 > Michael Tuexen wrote: >> tcp: restrict the contents of tcp_timer.h to the kernel context >> The header file contains only stuff relevant in the kernel = context. >> Reviewed by: glebius, rscheff, Peter Lei, imp >> Sponsored by: Netflix, Inc. >> Differential Revision: https://reviews.freebsd.org/D50912 >> --- >> sys/netinet/tcp_timer.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> diff --git a/sys/netinet/tcp_timer.h b/sys/netinet/tcp_timer.h >> index 875f1584988c..a145782ba82d 100644 >> --- a/sys/netinet/tcp_timer.h >> +++ b/sys/netinet/tcp_timer.h >> @@ -32,6 +32,8 @@ >> #ifndef _NETINET_TCP_TIMER_H_ >> #define _NETINET_TCP_TIMER_H_ >> +#ifdef _KERNEL >> + >> /* >> * The TCPT_REXMT timer is used to force retransmissions. >> * The TCP has the TCPT_REXMT timer set whenever segments >> @@ -133,8 +135,6 @@ >> (tv) =3D (tvmax); \ >> } while(0) >> -#ifdef _KERNEL >> - >> #define TP_KEEPINIT(tp) ((tp)->t_keepinit ? (tp)->t_keepinit : = tcp_keepinit) >> #define TP_KEEPIDLE(tp) ((tp)->t_keepidle ? (tp)->t_keepidle : = tcp_keepidle) >> #define TP_KEEPINTVL(tp) ((tp)->t_keepintvl ? (tp)->t_keepintvl : = tcp_keepintvl) > This broke net-mgmt/net-snmp, which uses at least TCPTV_MIN and = TCPTV_REXMTMAX. Hi Charlie, why is net-mgmt/net-snmp interested in the default value of the sysctl = variables net.inet.tcp.rexmit_min and net.inet.tcp.tcp_rexmit_max and not in the = current value of these sysctl variables? This does not make sense to me... Best regards Michael >=20 > --=20 > Charlie Li > ...nope, still don't have an exit line. >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BDD29F9A-1254-4631-B804-E10A523A8CC4>