Date: Thu, 6 Mar 2003 23:55:08 +0200 From: Ruslan Ermilov <ru@FreeBSD.org> To: "David O'Brien" <obrien@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/less Makefile lesspipe.sh Message-ID: <20030306215508.GA95318@sunbay.com> In-Reply-To: <20030306200858.GA41375@dragon.nuxi.com> References: <200303060435.h264Zmkk039395@repoman.freebsd.org> <20030306154915.GE55489@sunbay.com> <20030306181137.GB40027@dragon.nuxi.com> <20030306185824.GE78034@sunbay.com> <20030306200858.GA41375@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Mar 06, 2003 at 12:08:58PM -0800, David O'Brien wrote:
[...]
>
> > In any case, it's not _stupid_, as the default behavior of
> > SCRIPTSNAME of stripping extensions fits 99% of cases, and
> > it was designed bearing this in mind.
>
> Huh?? SCRIPTSNAME is only used when you need to over ride the default
> behavior. Perhaps you are talking about "SCRIPTS". What I think is
> stupid is that if I do use SCRIPTSNAME I still have to use SCRIPTS. Also
> as written, bsd.prog.mk doesn't handle this well:
>
> .for script in ${SCRIPTS}
> .if defined(SCRIPTSNAME)
> SCRIPTSNAME_${script:T}?= ${SCRIPTSNAME}
> .else
> SCRIPTSNAME_${script:T}?= ${script:T:R}
> .endif
>
> So what we have is SCRIPTS is a list, but SCRIPTSNAME name isn't.
> So what happens with
> ...
> SCRIPTS=foo.sh bar.sh
> SCRIPTSNAME=baz
> .include <bsd.prog.mk>
>
> both get installed as baz. SCRIPTS and SCRIPTSNAME should be treated
> separately. I'd fix it, but anytime I touch bsd.*.mk you pop up and I
> have a federal case on my hands -- thus I now try hard to never touch
> them.
>
What you wrote is an abuse. There are two intended usages:
1. SCRIPTS is single-value. Then you use SCRIPTSNAME.
2. SCRIPTS is multi-value. Then you use SCRIPTSNAME_<script>.
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)
iD8DBQE+Z8O8Ukv4P6juNwoRAlnMAJ4/qgK1zTAKkkmq/Tknvo7ZHeYfbACfYePh
eWeHvSCvdVzxh4z2xgkGhYA=
=D3sy
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030306215508.GA95318>