Date: Fri, 17 Jul 2009 19:26:46 GMT From: Ruud Althuizen <ruud@il.fontys.nl> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/136875: <software>_flags appending Message-ID: <200907171926.n6HJQk2r054311@www.freebsd.org> Resent-Message-ID: <200907171930.n6HJU2xm027611@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 136875
>Category: misc
>Synopsis: <software>_flags appending
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Fri Jul 17 19:30:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Ruud Althuizen
>Release: 7.2-STABLE
>Organization:
>Environment:
FreeBSD hyde.il.fontys.nl 7.2-STABLE FreeBSD 7.2-STABLE #0: Fri Jun 12 00:01:27 CEST 2009 root@hyde.il.fontys.nl:/usr/obj/usr/src/sys/HYDE i386
>Description:
When configuring software in /etc/rc.conf I sometimes find that I want to append something to <software>_flags instead of overwriting it. This may be the case for long lines or lines where the defaults are sensible but just missing stuff.
For example in the mailgraph rc-script, the default is:
: ${mailgraph_flags="--logfile /var/log/maillog --daemon-rrd=/var/db/mailgraph --ignore-localhost --daemon --daemon-pid=${mailgraph_pidfile}"
I just want the '--rbl-is-spam' flag added. In this case another problem occurs, predefined variables are used (the pidfile). So that would mean I need to define both or define them in one go.
>How-To-Repeat:
>Fix:
I propose to have /etc/rc.subr line 594 (eval rc_flags=\$${name}_flags) expanded to include something like \$${name}_flags_append
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907171926.n6HJQk2r054311>