Date: Sun, 29 Dec 2019 00:32:39 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org> Subject: Re: getting rid of sys/nfs/nfs_lock.c Message-ID: <YQBPR0101MB142764516978DF1172368738DD240@YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <YQBPR0101MB1427110476BAFA3C88E21564DD240@YQBPR0101MB1427.CANPRD01.PROD.OUTLOOK.COM>
index | next in thread | previous in thread | raw e-mail
Oh, I forgot to mention that, post March 2008, this code was replaced by the
in kernel nlm found in sys/nlm, which is why it has been in use.
________________________________________
From: owner-freebsd-current@freebsd.org <owner-freebsd-current@freebsd.org> on behalf of Rick Macklem <rmacklem@uoguelph.ca>
Sent: Saturday, December 28, 2019 7:30 PM
To: freebsd-current@freebsd.org
Subject: getting rid of sys/nfs/nfs_lock.c
Hi,
sys/nfs/nfs_lock.c uses Giant. Since it has not been used by default since
March 2008, I suspect it can be removed from head without any impact.
Post March 2008, the only way this code could be executed is by both
building a kernel without "options NFSLOCKD" and deleting nfslockd.ko
from the kernel boot directory and then running rpc.lockd on the system.
I doubt anyone has been doing both of the above, but if you think it is
still useful, please speak up. (I have an untested patch that replaces Giant
with a regular mutex. I realized this code is not used when I trying to test it.;-)
Also, if it seems appropriate, I could commit a patch that makes it print out
"deprecated and going away before FreeBSD 13" message, but I doubt anyone
will ever see it.
Should I do such a message and wait a few months for the deletion?
Thanks for your comments, rick
ps: The current patch that prepares the kernel for deletion of sys/nfs/nfs_lock.c
is in reviews.freebsd.org/D22933.
_______________________________________________
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YQBPR0101MB142764516978DF1172368738DD240>