Date: Tue, 20 Jan 2009 14:30:22 +0200 From: Kostik Belousov <kostikbel@gmail.com> To: Roman Divacky <rdivacky@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187468 - head/sys/ufs/ffs Message-ID: <20090120123022.GB58517@deviant.kiev.zoral.com.ua> In-Reply-To: <20090120115233.GA43828@freebsd.org> References: <200901201130.n0KBUM01043886@svn.freebsd.org> <20090120115233.GA43828@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--K8nIJk4ghYZn606h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 20, 2009 at 12:52:33PM +0100, Roman Divacky wrote: > On Tue, Jan 20, 2009 at 11:30:22AM +0000, Konstantin Belousov wrote: > > Author: kib > > Date: Tue Jan 20 11:30:22 2009 > > New Revision: 187468 > > URL: http://svn.freebsd.org/changeset/base/187468 > >=20 > > Log: > > When extending inode size, we call vnode_pager_setsize(), to have a > > address space where to put vnode pages, and then call UFS_BALLOC(), > > to actually allocate new block and map it. When UFS_BALLOC() returns > > error, sometimes we forget to revert the vm object size increase, > > allowing for the pages that are not backed by the logical disk blocks. > > =20 > > Revert vnode_pager_setsize() back when UFS_BALLOC() failed, for > > ffs_truncate() and ffs_write(). >=20 > can you describe in what scenario this can trigger? can it be that > many smallish (a few tens of kB?) of mmaped files being read/write > may cause this? The usual scenario is either a full partition or exceeded block quotas for the user that writes the file and then mmap it. --K8nIJk4ghYZn606h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkl1w90ACgkQC3+MBN1Mb4iyHACfSP8J1KUPlxC2ujeEMrrI20El VLUAnitW3DyAtfIJt0uGl5gMRsaag9Ne =5Yfo -----END PGP SIGNATURE----- --K8nIJk4ghYZn606h--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090120123022.GB58517>