Date: Thu, 4 Mar 2004 17:46:21 +0200 From: Peter Pentchev <roam@ringlet.net> To: cyrille.lefevre@laposte.net Cc: freebsd-qa@FreeBSD.org Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time Message-ID: <20040304154621.GA747@straylight.m.ringlet.net> In-Reply-To: <20040304152809.GA66105@gits.dyndns.org> References: <20040304152809.GA66105@gits.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
> cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET 2004)
> anyone to commit this PR ?
> thanks in advance.
>
[snip]
> /* Begin user dialog at outer menu */
> dialog_clear();
> + if (getpid() == 1)
> + dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max, FALSE);
> while (1) {
Just a minor comment: shouldn't RunningAsInit be used here instead of
a getpid() invocation? :)
G'luck,
Peter
--
Peter Pentchev roam@ringlet.net roam@sbnd.net roam@FreeBSD.org
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
This sentence contains exactly threee erors.
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAR09N7Ri2jRYZRVMRAlqKAKCTcAmVGc3Rc6afzhZmrg/Go4Y8OQCeN/ap
Rfl6hZllFD+ZxsXqxlOhHFk=
=qPre
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040304154621.GA747>