Date: Sun, 12 Mar 2017 12:26:26 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: "Ngie Cooper \(yaneurabeya\)" <yaneurabeya@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r308996 - head/lib/libfetch Message-ID: <86shmid9ct.fsf@desk.des.no> In-Reply-To: <93505FD7-FB42-4BD5-834C-6F73EFD9B1CF@gmail.com> (Ngie Cooper's message of "Sat, 11 Mar 2017 20:46:16 -0800") References: <201611221330.uAMDU7fg052989@repo.freebsd.org> <93505FD7-FB42-4BD5-834C-6F73EFD9B1CF@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
"Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> writes: > Hi Bjoern, No, that was my father :) > Shouldn=E2=80=99t this be strrchr instead of strchr since you=E2=80=99re > scanning for the service from the right side of the host, > e.g. =E2=80=9Cfoo:service=E2=80=9D or =E2=80=9C[::1]:service=E2=80=9D? Th= is code would match index 3 > in the first example, but it would match index 2 in the second > example. Correct, although it may be slightly more complicated, which is why I didn't immediately jump on it when bz@ pointed it out. I'm working on it right now. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86shmid9ct.fsf>