Date: Fri, 10 Jan 2003 13:03:39 -0600 (CST) From: Mike Silbersack <silby@silby.com> To: Doug Barton <DougB@FreeBSD.org> Cc: Maxime Henrion <mux@FreeBSD.org>, "" <cvs-committers@FreeBSD.org>, "" <cvs-all@FreeBSD.org> Subject: Re: cvs commit: src/sys/pci if_xl.c if_xlreg.h Message-ID: <20030110130229.C14055-200000@patrocles.silby.com> In-Reply-To: <20030109002237.U90866@2-234-22-23.pyvrag.nggov.pbz> References: <200212170008.gBH08owJ048742@repoman.freebsd.org> <3E1D29ED.8030804@dougbarton.net> <20030109021139.C6353-100000@patrocles.silby.com> <20030109002237.U90866@2-234-22-23.pyvrag.nggov.pbz>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Thu, 9 Jan 2003, Doug Barton wrote:
> On Thu, 9 Jan 2003, Mike Silbersack wrote:
>
> > I'd suggest adding some code to doublecheck that the chip actually came
> > out of the D3 state before continuing on. The failure you're reporting
> > comes too soon and at too low of a level to be due to any of the changes
> > Maxime or I have done recently.
>
> OK... thanks for letting me know. Adding that kind of code is beyond me,
> but if someone more knowledgable wants to send me patches, I'll be happy
> to give them a try.
>
> Doug
Give this patch a try, see what it says. I added both the check to
doublecheck that it came out of powersaving, and a bit of delay to perhaps
give it time to do so.
Mike "Silby" Silbersack
[-- Attachment #2 --]
--- /usr/src/sys.old/pci/if_xl.c Mon Dec 30 22:55:02 2002
+++ if_xl.c Fri Jan 10 13:02:01 2003
@@ -1362,12 +1362,16 @@
pci_get_powerstate(dev));
pci_set_powerstate(dev, PCI_POWERSTATE_D0);
+ DELAY(10000);
/* Restore PCI config data. */
pci_write_config(dev, XL_PCI_LOIO, iobase, 4);
pci_write_config(dev, XL_PCI_LOMEM, membase, 4);
pci_write_config(dev, XL_PCI_INTLINE, irq, 4);
}
+
+ if (pci_get_powerstate(dev) != PCI_POWERSTATE_D0)
+ printf("Doug Barton's 3c556B card didn't come out of powersaving!");
/*
* Map control/status registers.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030110130229.C14055-200000>