Date: Mon, 18 Sep 2017 17:12:01 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Conrad Meyer <cem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r323692 - in head/sys/compat: linsysfs linux Message-ID: <74fa25ac-685e-c3f8-90d6-cdfac10a0f88@selasky.org> In-Reply-To: <201709172340.v8HNeGuP016998@repo.freebsd.org> References: <201709172340.v8HNeGuP016998@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 09/18/17 01:40, Conrad Meyer wrote:
> +
> + dinfo = device_get_ivars(parent);
> + if (dinfo != NULL && dinfo->cfg.baseclass == PCIC_DISPLAY) {
> + devclass = device_get_devclass(dev);
> + if (devclass != NULL)
> + name = devclass_get_name(devclass);
> + if (name != NULL && strcmp(name, DRMN_DEV) == 0 &&
> + device_get_unit(dev) >= 0) {
> + sprintf(chardevname, "226:%d",
Order of comparison should be switched.
First check devclass and name.
Then try to access ivars. Else the ivars might have an undefined type!
--HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?74fa25ac-685e-c3f8-90d6-cdfac10a0f88>