Date: Tue, 1 Feb 2011 13:32:27 +0000 (UTC) From: Lawrence Stewart <lstewart@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/netinet cc.h src/sys/netinet/cc cc_newreno.c Message-ID: <201102011332.p11DWtKn001988@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
lstewart 2011-02-01 13:32:27 UTC
FreeBSD src repository
Modified files:
sys/netinet cc.h
sys/netinet/cc cc_newreno.c
Log:
SVN rev 218167 on 2011-02-01 13:32:27Z by lstewart
Algorithm modules can define their own private congestion signal types in the
top 8 bits of the 32 bit signal bit field space for internal use. These private
signals should not be leaked outside of a module.
Given that many algorithm modules use the NewReno hook functions to simplify
their implementation, the obvious place such a leak would show up is in the
NewReno cong_signal hook function.
- Show the full number of significant bits in the signal type definitions in
<netinet/cc.h>.
- Add a bitmask to simplify figuring out if a given signal is in the private or
public bit range.
- Add a sanity check in newreno_cong_signal() to ensure private signals are not
being leaked into the hook function.
Sponsored by: FreeBSD Foundation
Discussed with: David Hayes <dahayes at swin edu au>
MFC after: 1 week
X-MFC with: r215166
Revision Changes Path
1.4 +6 -4 src/sys/netinet/cc.h
1.4 +4 -0 src/sys/netinet/cc/cc_newreno.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201102011332.p11DWtKn001988>