Date: Sat, 8 Sep 2001 03:15:27 +0100 From: Josef Karthauser <joe@tao.org.uk> To: Peter Wemm <peter@wemm.org> Cc: Will Andrews <will@physics.purdue.edu>, Ruslan Ermilov <ru@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Contracting $FreeBSD: xxx $ in commits (Re: cvs commit: src/include stddef.h) Message-ID: <20010908031527.X3148@tao.org.uk> In-Reply-To: <20010526220826.7CE6238CB@overcee.netplex.com.au>; from peter@wemm.org on Sat, May 26, 2001 at 03:08:26PM -0700 References: <20010525023459.E7406@casimir.physics.purdue.edu> <20010526220826.7CE6238CB@overcee.netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, May 26, 2001 at 03:08:26PM -0700, Peter Wemm wrote: > Will Andrews wrote: > > On Fri, May 25, 2001 at 09:51:10AM +0300, Ruslan Ermilov wrote: > > > How that could be? Don't we count the '$FreeBSD$' line? > > > > Not necessarily. Only when the previous commit that was made was made > > w/o the rcsid expanded. I've made several "+0 -0" commits before. :-) > > If the previous commit had the tag changed to "$FreeBSD$" and the current > commit had it as "$FreeBSD$" then you get this. The tags are expanded > on *checkout*, not checkin. If you have: "$FreeBSD: is excellent $" > then that is what actually goes into the rcs files. > > I have contemplated in the past making the commit checkin scripts change > any expanded $FreeBSD: foo $ tags into plain $FreeBSD$ so that it doesn't > keep occupying rcs delta space, but I was concerned about potential > interactions with remote commits and the 'touched but not actually > modified' checking. It would be worth experimenting with I think. It is > silly that we have +1 -1 on most commits solely because of the header > changes. I've just committed code to handle this. It works fine with remote commits in my tests, and the 'touched by not actually modified' issue doesn't appear to be one. Maybe it's a bug that was fixed in a more recent version of cvs? Joe [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.6 (FreeBSD) Comment: For info see http://www.gnupg.org iEYEARECAAYFAjuZfz8ACgkQXVIcjOaxUBb9FQCg6rDjuGCP6N7YTL38h9w3ljKO EacAoI6jtOzVl7GhBmOlOwbQKX5Nge5j =hUCg -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20010908031527.X3148>