Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 02 May 2017 22:58:24 +0000
From:      Eric Joyner <erj@freebsd.org>
To:        Ngie Cooper <yaneurabeya@gmail.com>, Ed Maste <emaste@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>,  "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-stable@freebsd.org" <svn-src-stable@freebsd.org>,  "svn-src-stable-10@freebsd.org" <svn-src-stable-10@freebsd.org>
Subject:   Re: svn commit: r315333 - in stable/10/sys: conf dev/ixgbe modules/ix modules/ixv
Message-ID:  <CA%2Bb0zg807h1irL3myv24o3kkPSxCYw80VnbmSdkYtFGqJmeLgg@mail.gmail.com>
In-Reply-To: <CA%2Bb0zg-nTD8MB8Fpqtzbe0OZVC5-nE%2Bpx8Sa9zvju0NG=GGjog@mail.gmail.com>
References:  <201703152120.v2FLKHUs052999@repo.freebsd.org> <CAPyFy2AQz7SdGey1pATDM2vnmGinkAn%2BB=6nwiYfLFn-AU7p=g@mail.gmail.com> <CAGHfRMAOf=T8KxKDUkVWCp8VXaWy59U5=nF6coZ3-K4LcQojmw@mail.gmail.com> <CA%2Bb0zg-nTD8MB8Fpqtzbe0OZVC5-nE%2Bpx8Sa9zvju0NG=GGjog@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
I fixed the netmap build for amd64 at least with r317711. I'm running a
tinderbox build on it now, though, so I'll see if that fixes it.

On Fri, Apr 28, 2017 at 1:40 PM Eric Joyner <erj@freebsd.org> wrote:

> I notified Jeb (the original patch submitter) about that netmap symbol
> issue, but we've both been distracted with other development. I'll work on
> updating it.
>
> - Eric
>
> On Thu, Apr 27, 2017 at 3:06 PM Ngie Cooper <yaneurabeya@gmail.com> wrote:
>
>> On Thu, Apr 27, 2017 at 1:07 PM, Ed Maste <emaste@freebsd.org> wrote:
>> > On 15 March 2017 at 17:20, Eric Joyner <erj@freebsd.org> wrote:
>> >> Author: erj
>> >> Date: Wed Mar 15 21:20:17 2017
>> >> New Revision: 315333
>> >> URL: https://svnweb.freebsd.org/changeset/base/315333
>> >>
>> >> Log:
>> >>   ixgbe(4): Update to 3.2.11-k
>> >
>> > This broke tinderbox on many architectures:
>> >
>> > ia64 GENERIC and powerpc GENERIC64:
>> >
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:39: warning: no
>> > previous prototype for 'ixv_read_pci_cfg' [-Wmissing-prototypes]
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_osdep.c:45: warning: no
>> > previous prototype for 'ixv_write_pci_cfg' [-Wmissing-prototypes]
>> >
>> > sparc64 LINT:
>> >
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ix_txrx.c:43: warning:
>> > redundant redeclaration of 'ix_crcstrip' [-Wredundant-decls]
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.h:45: warning:
>> > previous declaration of 'ix_crcstrip' was here
>> >
>> > amd64 LINT:
>> >
>> > /scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixv_netmap.c:(.text+0x0):
>> > multiple definition of `ixgbe_netmap_attach'
>> >
>> ixgbe_netmap.o:/scratch/tmp/emaste/freebsd/sys/dev/ixgbe/ixgbe_netmap.c:(.text+0x0):
>> > first defined here
>>
>> Hi Ed,
>>
>> It has to do with netmap(4) refactoring on head not being backported,
>> in combination with ixgbe/ix being MFCed in a refactored state back to
>> ^/stable/10 (it wasn't easy to backport due to PCI-IOV only being on
>> ^/stable/10 -- I tried starting this work and failed because I lacked
>> the hardware to test this out with).
>>
>> This has been known to be broken for almost two months -- a surgical
>> fix should probably be applied to do what's required to make the
>> symbol appear in the appropriate places, since this basically was a
>> direct commit to ^/stable/10 in some regards.
>>
>> Thanks,
>> -Ngie
>>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2Bb0zg807h1irL3myv24o3kkPSxCYw80VnbmSdkYtFGqJmeLgg>