Date: Sun, 28 Nov 1999 17:19:53 -0800 (PST) From: Matthew Dillon <dillon@apollo.backplane.com> To: Kris Kennaway <kris@hub.freebsd.org> Cc: Dan Moschuk <dan@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/conf files.i386 src/sys/kern kern_fork.c src/sys/libkern arc4random.c src/sys/sys libkern.h Message-ID: <199911290119.RAA47318@apollo.backplane.com> References: <Pine.BSF.4.21.9911281109500.80171-100000@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
:
:Reviewed and Not Approved by: kris. You're using a weak seeding mechanism
:and a handmade arc4 implementation which is not as good as the one we
:already have in libc.
:
:IMO, if you ask for a review and get objections, you should wait to
:address them before actually committing..otherwise, what's the point?
:
:> Revision Changes Path
:> 1.282 +2 -1 src/sys/i386/conf/files.i386
:> 1.70 +6 -3 src/sys/kern/kern_fork.c
:> 1.19 +2 -1 src/sys/sys/libkern.h
:
:Plus. you seem to have failed to commit the arc4.c :-)
:
:Kris
:
:----
I sure hope the algorithm does not recycle PIDs for a reasonable amount
of time, or you may end up with a race in scripts that kill processes
via their /var/run pid's. You know: kill -HUP, then kill -9 sequences
and such.
-Matt
Matthew Dillon
<dillon@backplane.com>
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199911290119.RAA47318>