Date: Thu, 28 Apr 2005 09:27:08 -0600 From: Scott Long <scottl@samsco.org> To: Ruslan Ermilov <ru@freebsd.org> Cc: current@freebsd.org Subject: Re: LINT broken due to ipfilter Message-ID: <427100CC.8080604@samsco.org> In-Reply-To: <20050428152622.GC92579@ip.net.ua> References: <20050428025836.E1ED67306E@freebsd-current.sentex.ca> <20050428145519.GB92579@ip.net.ua> <4270FB26.50805@samsco.org> <20050428152622.GC92579@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Ruslan Ermilov wrote:
> Hi Scott,
>
> On Thu, Apr 28, 2005 at 09:03:02AM -0600, Scott Long wrote:
>
>>Ruslan Ermilov wrote:
>>
>>>The changes from sys/modules/ipfilter/Makefile,v 1.17 should be propagated
>>>to sys/conf/{files,options,NOTES}.
>>>
>>>
>>>Cheers,
>>
>>Please feel free to do this.
>>
>
> Well, the attached patch should do it, though I have near zero experience
> with ipfilter, so I won't commit it myself. Darren probably will. :-)
>
> Even after committing this, there's stil a number of compile-time warnings
> on 64-bit platforms that should be fixed before this can be compiled.
> Before this, it probably makes sense to comment out IPFILTER in LINT,
> and let Darren finish polishing his import.
>
It's been three days, I think that we've all been patient enough. I
meant to fix it yesterday, but forgot to check LINT. Please either
commit what you have or comment IPFILTER out of LINT. Either way, it's
been more than long enough and you should not be afraid of stepping on
any toes or being yelled at.
Leaving the tree unbuildable for 3 days is unacceptable. I doubt that
any other active OSS project would tolerate it, and I'm sure that Sun
wouldn't tolerate it either.
Scott
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?427100CC.8080604>