Date: Fri, 14 Dec 2001 16:58:32 -0800 From: "Crist J . Clark" <cjc@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: Guido van Rooij <guido@gvr.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc/periodic/security 550.ipfwlimit 650.ip6fwlimit Message-ID: <20011214165832.B3473@blossom.cjclark.org> In-Reply-To: <20011214142928.A69958@sunbay.com>; from ru@FreeBSD.org on Fri, Dec 14, 2001 at 02:29:28PM %2B0200 References: <200112140858.fBE8wL596075@freefall.freebsd.org> <20011214115711.A34932@gvr.gvr.org> <20011214135243.B64853@sunbay.com> <20011214125438.A35615@gvr.gvr.org> <20011214142928.A69958@sunbay.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 14, 2001 at 02:29:28PM +0200, Ruslan Ermilov wrote:
> On Fri, Dec 14, 2001 at 12:54:38PM +0100, Guido van Rooij wrote:
> > On Fri, Dec 14, 2001 at 01:52:43PM +0200, Ruslan Ermilov wrote:
> > > On Fri, Dec 14, 2001 at 11:57:11AM +0100, Guido van Rooij wrote:
> > > > On Fri, Dec 14, 2001 at 12:58:21AM -0800, Ruslan Ermilov wrote:
> > > > > ru 2001/12/14 00:58:21 PST
> > > > >
> > > > > Modified files:
> > > > > etc/periodic/security 550.ipfwlimit 650.ip6fwlimit
> > > > > Log:
> > > > > Work around the bugfeature of test(1).
> > > > >
> > > > > PR: bin/32822
> > > >
> > > >
> > > > If I run this:
> > > > if [ 0 -eq 0 -a "" -ne 1 ];
> > > > then echo foo
> > > > fi
> > > > then it works. Isn't the real problem that "${IPFW_LOG_LIMIT}" gets lost
> > > > somehow?
> > > >
> > > Nope, try this:
> > >
> > > FOO=
> > > if [ 0 -eq 1 -a ${FOO} -ne 1 ]; then
> > > echo OK
> > > fi
> > >
> > > An alternate solution would be to write:
> > >
> > > if [ 0 -eq 1 -a "${FOO}" -ne 1 ]; then
> >
> > But that is what was in /etc/security.. So why did it fail?
> >
> Now I feel really confused. I could reproduce this at the
> morning, but couldn't after reading your mail. Fortunately,
> I've figured what's different:
>
> $ /STABLE/bin/[ "" -eq 0 ]
> $ /CURRENT/bin/[ "" -eq 0 ]
> [: : out of range
>
> I'll investigate what's wrong with -current's /bin/[ shortly
> and will back my (not actually relevant) changes out.
Isn't test(1) now a sh(1) builtin on CURRENT?
I was wondering why this "bug" was never seen in STABLE when the code
is identical.
--
"It's always funny until someone gets hurt. Then it's hilarious."
Crist J. Clark | cjclark@alum.mit.edu
| cjclark@jhu.edu
http://people.freebsd.org/~cjc/ | cjc@freebsd.org
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20011214165832.B3473>