Date: Thu, 18 Jul 2002 14:46:24 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: John Baldwin <jhb@FreeBSD.org> Cc: Mark Murray <markm@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: RE: cvs commit: src/sys/i386/include atomic.h Message-ID: <20020718143939.M7896-100000@gamplex.bde.org> In-Reply-To: <XFMail.20020717133607.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 17 Jul 2002, John Baldwin wrote: > On 17-Jul-2002 Mark Murray wrote: > > markm 2002/07/17 09:19:37 PDT > > > > Modified files: > > sys/i386/include atomic.h > > Log: > > Clean up the syntax WRT semicolons at the end of function-like-macros, and protect GCCisms from > > non-GNU compilers and lint. > > I would prefer you use #error instead of non-working dummy functions. This file already used #error for that. The purpose of the commit is to specially break this for lint only. I would prefer the file to be correctly ifdefed and fall back to extern functions in cases that can't be implemented inline, much like <machine/cpufunc.h>. Then it could be compiled by any C compiler. The kernel just wouldn't link unless the extern functions were actually implemented somewhere, and might run much slower if they were implemented. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020718143939.M7896-100000>