Date: Sun, 7 Dec 2003 22:21:06 -0800 (PST) From: Nate Lawson <nate@root.org> To: Paul Saab <ps@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_da.c Message-ID: <20031207221626.L36956@root.org> In-Reply-To: <20031208051448.87BCD16A53C@hub.freebsd.org> References: <20031208051448.87BCD16A53C@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 7 Dec 2003, Paul Saab wrote:
> Modified files:
> sys/cam/scsi scsi_da.c
> Log:
> ciss doesn't like scsi SYNC CACHE. turn it off
>
> Revision Changes Path
> 1.161 +8 -0 src/sys/cam/scsi/scsi_da.c
>
> --- src/sys/cam/scsi/scsi_da.c:1.160 Wed Oct 8 00:12:30 2003
> +++ src/sys/cam/scsi/scsi_da.c Sun Dec 7 21:14:13 2003
> @@ -376,6 +376,14 @@
> {T_DIRECT, SIP_MEDIA_REMOVABLE, "CREATIVE", "NOMAD_MUVO", "*"},
> /*quirks*/ DA_Q_NO_SYNC_CACHE|DA_Q_NO_PREVENT
> },
> + {
> + /*
> + * The CISS RAID driver drives dont like the cache to be
> + * sync'd (esp since write cache is turned off).
> + */
> + {T_DIRECT, SIP_MEDIA_FIXED, "COMPAQ", "RAID*", "*"},
> + /*quirks*/ DA_Q_NO_SYNC_CACHE
> + },
> };
>
> static disk_strategy_t dastrategy;
Please place quirks in the proper section. I believe you put that one in
the USB section. It would also help if you described what happens when
they are sent a SYNC_CACHE (i.e. hang). Most useful would be a PR entry
with the dmesg and description of the behavior. The reason for this is
that especially in the USB case, many quirks had proliferated that were
overly wildcarded and which weren't actually needed but there was no way
to be certain which were needed and which weren't. It would be nice to
know when we can remove the quirk if this turns out to be an underlying
driver problem and not a drive problem.
Thanks,
Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031207221626.L36956>