Date: Sat, 11 Apr 2009 12:43:35 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Ed Schouten <ed@freebsd.org> Subject: Re: svn commit: r190919 - in head/sys: amd64/amd64 amd64/include i386/i386 i386/include Message-ID: <20090411124335.0600a72f@kan.dnsalias.net> In-Reply-To: <20090411163528.GC46526@troutmask.apl.washington.edu> References: <200904111401.n3BE1108088009@svn.freebsd.org> <20090411163528.GC46526@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sat, 11 Apr 2009 09:35:28 -0700 Steve Kargl <sgk@troutmask.apl.washington.edu> wrote: > On Sat, Apr 11, 2009 at 02:01:01PM +0000, Ed Schouten wrote: > > Author: ed > > Date: Sat Apr 11 14:01:01 2009 > > New Revision: 190919 > > URL: http://svn.freebsd.org/changeset/base/190919 > > > > Log: > > Simplify in/out functions (for i386 and AMD64). > > > > Remove a hack to generate more efficient code for port numbers > > below 0x100, which has been obsolete for at least ten years, > > because GCC has an asm constraint to specify that. > > > > Submitted by: Christoph Mallon <christoph mallon gmx de> > > > > I thought Christoph and bde were still hashing out the correctness > of this patch. > > http://lists.freebsd.org/pipermail/freebsd-amd64/2009-April/012064.html > > -- > Steve The patch is inconsistent in regards to usage of volatile vs. __volatile even within itself. I think the code is sloppy and was not ready to be committed yet. Please fix or back out. -- Alexander Kabaev [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iD8DBQFJ4Mi8Q6z1jMm+XZYRAs1wAJ9R0s0eYED/siLAQ9OMMQAYThLKLgCgy/gX i3ACSeLv6QxxoP1TYXumCok= =WmK8 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090411124335.0600a72f>