Date: Thu, 7 Feb 2019 11:45:15 +0100 From: Marius Strobl <marius@freebsd.org> To: Vincenzo Maffione <vmaffione@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343772 - head/sys/dev/netmap Message-ID: <20190207104515.GA92760@alchemy.franken.de> In-Reply-To: <201902051210.x15CAnPq052340@repo.freebsd.org> References: <201902051210.x15CAnPq052340@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 05, 2019 at 12:10:49PM +0000, Vincenzo Maffione wrote: > Author: vmaffione > Date: Tue Feb 5 12:10:48 2019 > New Revision: 343772 > URL: https://svnweb.freebsd.org/changeset/base/343772 > > Log: > netmap: refactor logging macros and pipes > > Changelist: > - Replace ND, D and RD macros with nm_prdis, nm_prinf, nm_prerr > and nm_prlim, to avoid possible naming conflicts. > - Add netmap_krings_mode_commit() helper function and use that > to reduce code duplication. > - Refactor pipes control code to export some functions that > can be reused by the veth driver (on Linux) and epair(4). > - Add check to reject API requests with version less than 11. > - Small code refactoring for the null adapter. Hello Vincenzo, this change causes interface attachment output to look somewhat deformed ("000.000395 [3717] netmap_attach_ext" debug info and an extra newline): em0: <Intel(R) PRO/1000 Network Connection> port 0xe000-0xe01f mem 0xf7d00000-0xf7d1ffff,0xf7d20000-0xf7d23fff irq 17 at device 0.0 on pci3 em0: Using 1024 TX descriptors and 1024 RX descriptors em0: Using 2 RX queues 2 TX queues em0: Using MSI-X interrupts with 3 vectors em0: Ethernet address: 60:a4:4c:24:0b:4c 000.000395 [3717] netmap_attach_ext em0: netmap queues/slots: TX 2/1024, RX 2/1024 pcib5: <ACPI PCI-PCI bridge> irq 19 at device 28.7 on pci0 Could we please get this part back to match the pre-r343772 output again? Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190207104515.GA92760>