Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 1 Feb 2008 04:46:50 GMT
From:      Warner Losh <imp@FreeBSD.org>
To:        Perforce Change Reviews <perforce@freebsd.org>
Subject:   PERFORCE change 134580 for review
Message-ID:  <200802010446.m114koOO056292@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=134580

Change 134580 by imp@imp_lighthouse on 2008/02/01 04:46:06

	No need to bzero .bss.  The boot loader already does this.
	There is a need to parse the boot loader's info that was
	inadvertantly removed from a prior version.

Affected files ...

.. //depot/projects/mips2-jnpr/src/sys/mips/mips32/octeon32/octeon_machdep.c#6 edit

Differences ...

==== //depot/projects/mips2-jnpr/src/sys/mips/mips32/octeon32/octeon_machdep.c#6 (text+ko) ====

@@ -1024,9 +1024,8 @@
 }
 
 
-void mips_boot_params_init(void);
-
-void mips_boot_params_init (void)
+static void
+mips_boot_params_init(void)
 {
     int descriptor_not_parsed = 1;
 
@@ -1249,17 +1248,16 @@
 
         mips_platform_init();
 
-	/* clear the BSS and SBSS segments */
+	/* The boot loader clears the BSS and SBSS segments */
 	kernend = round_page((vm_offset_t)&end);
-	memset(&edata, 0, kernend - (vm_offset_t)(&edata));
-
 
 	tick_early_init(OCTEON_CLOCK_DEFAULT);  /* Quick Default. To avoid divide-by-0
                                                  * Later we will get it from
                                                  * Bootloader/Rom-Mon */
 
 	cninit();
-        printf(" Initialized memory: 0x%p  to  0x%lX\n", &edata, ((long) &edata) + ((long)kernend - (long)(&edata)));
+	mips_boot_params_init();
+	printf(" Initialized memory: 0x%p  to  0x%lX\n", &edata, ((long) &edata) + ((long)kernend - (long)(&edata)));
 
 	mips_init();
 	uint64_t platform_counter_freq = OCTEON_CLOCK_DEFAULT;



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200802010446.m114koOO056292>