Date: Wed, 17 Jun 2020 17:43:58 -0700 From: Conrad Meyer <cem@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362253 - head/sys/vm Message-ID: <CAG6CVpUmzZyt0duC0P%2Bj0Ac4iW%2Bwx9UFQafJuDeaHYo_QXs35g@mail.gmail.com> In-Reply-To: <20200617110419.GF45690@kib.kiev.ua> References: <202006162253.05GMruKi046200@repo.freebsd.org> <20200617110419.GF45690@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 17, 2020 at 4:04 AM Konstantin Belousov <kostikbel@gmail.com> w= rote: > > On Tue, Jun 16, 2020 at 10:53:56PM +0000, Conrad Meyer wrote: > > Author: cem > > Date: Tue Jun 16 22:53:56 2020 > > New Revision: 362253 > > URL: https://svnweb.freebsd.org/changeset/base/362253 > > > > Log: > > vm: Drop vm_map_clip_{start,end} macro wrappers > > > > No functional change. > > > > Reviewed by: dougm, markj > > Sponsored by: Dell EMC Isilon > > Differential Revision: https://reviews.freebsd.org/D25282 > > I would highly appreciate if you revert this commit. > It conflicts with https://reviews.freebsd.org/D24652, which must revert y= our > change to remain functional. > I probably should not allowed that review to rott silently. Initially, I took a similar approach =E2=80=94 converting the macros to inl= ine functions. It was suggested in the review to just merge them, as they were both relatively small. I have a follow-up patch which will add a small amount of code to the former macros. (D25283) I don't think there is any functional reason your patch cannot be rebased over this change. You could choose to merge _vm_map_clip_start and vm_map_clip_start (and same for end) in your patch; nothing invokes the underscore variants except the wrappers. You could also choose to re-split the routines, although I'm not sure why. Either option seems acceptable to me. Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpUmzZyt0duC0P%2Bj0Ac4iW%2Bwx9UFQafJuDeaHYo_QXs35g>