Date: Sun, 11 Nov 2018 07:17:27 +0800 From: Ben Woods <woodsb02@gmail.com> To: rgrimes@freebsd.org Cc: Ben Woods <woodsb02@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340326 - head Message-ID: <CAOc73CCSTx1RMm0B-kBQ7f3TQRe6v=5vr4EgQjAvRUM6KcKTnA@mail.gmail.com> In-Reply-To: <201811101843.wAAIhKrg016961@pdx.rh.CN85.dnsmgr.net> References: <201811101658.wAAGw8Zd032024@repo.freebsd.org> <201811101843.wAAIhKrg016961@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 11 Nov 2018 at 2:43 am, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > If your going to bother with a differential, and invite people to > it you should give them at least 24 hours, and preferably 72 hours > to respond to the new review. Reviews that last < 4 hours are not > code reviews. > > -- > Rod Grimes > rgrimes@freebsd.org > Hi Rod, Sorry. The main reason I submitted the code review is because I do not have my src commit bit, so needed to seek approval to commit. I felt the need to commit the UPDATING entry was time sensitive, given the change it was notifying users of had already been committed. Regards, Ben -- -- From: Benjamin Woods woodsb02@gmail.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOc73CCSTx1RMm0B-kBQ7f3TQRe6v=5vr4EgQjAvRUM6KcKTnA>