Date: Wed, 17 Jun 2020 17:48:13 -0700 From: Conrad Meyer <cem@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Eric van Gyzen <vangyzen@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r362126 - head/sys/vm Message-ID: <CAG6CVpX7oVK00SCscDRo6yLg_HsddF8jhu50Vzp3veTWqyc61Q@mail.gmail.com> In-Reply-To: <cdbd93bd-ddea-87fc-c361-90364f82ea6f@FreeBSD.org> References: <202006122153.05CLr8JN091722@repo.freebsd.org> <CAG6CVpXR6BH6kPKGURH9aHFs829XCB1CRvjm3eciEufDdBXmMA@mail.gmail.com> <cdbd93bd-ddea-87fc-c361-90364f82ea6f@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 17, 2020 at 10:50 AM John Baldwin <jhb@freebsd.org> wrote: > > On 6/12/20 3:33 PM, Conrad Meyer wrote: > > On Fri, Jun 12, 2020 at 2:53 PM Eric van Gyzen <vangyzen@freebsd.org> wrote: > >> Honor db_pager_quit in some vm_object ddb commands > >> > >> These can be rather verbose. > > > > We also have this (?)hack in OneFS, which eliminates the need for > > every debug function to check the db_pager globals: > > > > https://people.freebsd.org/~cem/db_pager.patch > > > > I'm not sure how objectionable it is. > > I don't think this addresses that. I think this patch makes printf turn > into db_printf when a function is invoked from DDB which is orthogonal. > db_printf() itself doesn't check the pager. db_printf checks the pager, via db_putc.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpX7oVK00SCscDRo6yLg_HsddF8jhu50Vzp3veTWqyc61Q>