Date: Sat, 31 Aug 2019 00:03:08 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Oliver Pinter <oliver.pinter@hardenedbsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r351471 - in head/sys: kern sys Message-ID: <CAGudoHG8%2BrnK8j8BwD5HA6CyGoXMyipu0=upXYsuaKJV7-wcXQ@mail.gmail.com> In-Reply-To: <CAPQ4fftD57MXX8BpJB2RxNBdR2Ur144mSkB=nMiyFJU4KDs0=w@mail.gmail.com> References: <201908250511.x7P5BiPl016074@repo.freebsd.org> <CAPQ4fftD57MXX8BpJB2RxNBdR2Ur144mSkB=nMiyFJU4KDs0=w@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/25/19, Oliver Pinter <oliver.pinter@hardenedbsd.org> wrote: > On Sunday, August 25, 2019, Mateusz Guzik <mjg@freebsd.org> wrote: > >> Author: mjg >> Date: Sun Aug 25 05:11:43 2019 >> New Revision: 351471 >> URL: https://svnweb.freebsd.org/changeset/base/351471 >> >> Log: >> vfs: add vholdnz (for already held vnodes) > > > Why? > > (Yes, is can read the real reason in phabricator, but the phabricator > didn't considered a persistent information in relation to commit message. > Review helper tool just comes and goes as time goes forward, but commit > messages survives the repo conversions to other VCS...) > > And once you have taken the time to write a correct description in > phabricator, it would be really really nice and helpful if you would copy > them into commit message. > I think it's a fair point that if I included this info in the review it should make it's way into the commit message. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHG8%2BrnK8j8BwD5HA6CyGoXMyipu0=upXYsuaKJV7-wcXQ>