Date: Thu, 26 May 2011 09:18:03 -0700 From: mdf@FreeBSD.org To: Andriy Gapon <avg@freebsd.org> Cc: Attilio Rao <attilio@freebsd.org>, src-committers@freebsd.org, Pawel Jakub Dawidek <pjd@freebsd.org>, svn-src-user@freebsd.org Subject: Re: svn commit: r222060 - in user/avg/xcpu/sys: kern sys Message-ID: <BANLkTi=X_zddoAbZfXqtuzLut16zCVi%2BTg@mail.gmail.com> In-Reply-To: <4DDE7A36.2050104@FreeBSD.org> References: <201105181508.p4IF8UoS096841@svn.freebsd.org> <20110518182441.GB2273@garage.freebsd.pl> <4DD4243C.4070301@FreeBSD.org> <BANLkTikAnB-3XbvDwGHgyqyJquH9BhqzOQ@mail.gmail.com> <4DDD13F9.5040800@FreeBSD.org> <4DDE7555.7090500@FreeBSD.org> <BANLkTim_zEDPANqZTpyYdOKqDaPEc8EhVg@mail.gmail.com> <4DDE7A36.2050104@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 26, 2011 at 9:05 AM, Andriy Gapon <avg@freebsd.org> wrote: > on 26/05/2011 18:46 mdf@FreeBSD.org said the following: >> A per-thread flag is needed as long as other CPUs can be running or >> even just the scheduler on the remaining CPU. =A0So I would thing that >> flag needs to be checked until the system has been massaged to the >> state you describe above. > > I am not sure that I understand your reasoning if you mean that the flag = needs to > be checked in TD_IS_INPANIC. =A0That is, right now there is no TD_IS_INPA= NIC and > things work after panic to a certain degree. =A0I do not intend to improv= e that > degree and just want to keep an option to revert to the current state of = matters. > When TD_IS_INPANIC is introduced and stop_cpus_on_panic=3D=3D1, then ther= e will be > only one thread left running after panic, that will be the thread that ca= lled > panic, checking TDF_INPANIC just doesn't add anything. Won't the scheduler still run even if other CPUs are halted? Is there any intent to prevent switching to another thread? (I suppose this could be achieved by setting td_critnest++ and wouldn't require a flag). It's possible I misunderstood your email so my response may have been non-sensical. Thanks, matthew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTi=X_zddoAbZfXqtuzLut16zCVi%2BTg>