Date: Sat, 14 Nov 2015 10:26:28 -0700 From: Warner Losh <imp@bsdimp.com> To: Bryan Drewery <bdrewery@freebsd.org> Cc: Andrew Turner <andrew@fubar.geek.nz>, Edward Tomasz Napierala <trasz@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r290821 - head/usr.sbin/ctld Message-ID: <CANCZdfponmorzwqeUwKY7mGMXm18aMJQkSHdRrL%2B8GpgTv_zSg@mail.gmail.com> In-Reply-To: <56476DD6.5010805@FreeBSD.org> References: <201511141606.tAEG61Rh062202@repo.freebsd.org> <20151114172030.7dfc24d0@bender.Home> <56476DD6.5010805@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Nov 14, 2015 at 10:22 AM, Bryan Drewery <bdrewery@freebsd.org> wrote: > On 11/14/2015 9:20 AM, Andrew Turner wrote: > > On Sat, 14 Nov 2015 16:06:01 +0000 (UTC) > > Edward Tomasz Napierala <trasz@FreeBSD.org> wrote: > > > >> Author: trasz > >> Date: Sat Nov 14 16:06:01 2015 > >> New Revision: 290821 > >> URL: https://svnweb.freebsd.org/changeset/base/290821 > >> > >> Log: > >> Don't try to avoid calling free(3) with NULL argument. > > > > Why? free(NULL) is documented to be a nop and is safe to rely on this > > behaviour. > > > > You read it backwards, see the change. It's doing what you want. > Or rather, its failing to not do what you want. The double negative can be tricky :) Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfponmorzwqeUwKY7mGMXm18aMJQkSHdRrL%2B8GpgTv_zSg>